printing/printing_context_android.cc - Issue 63483007: Refactor Android printing code to make it more testable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/printing_context_android.cc

Issue 63483007: Refactor Android printing code to make it more testable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved isPrintingController into PrintingControllerImpl, cleaned tiny bits Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« printing/android/java/src/org/chromium/printing/SystemPrintManagerDelegate.java ('K') | « printing/android/java/src/org/chromium/printing/SystemPrintManagerDelegate.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: printing/printing_context_android.cc

diff --git a/printing/printing_context_android.cc b/printing/printing_context_android.cc

index 79693d7df102889aebb60d9a969d1ef16ca33add..d1df905083e41342b518eaae3d0b2e28d1ed3126 100644

--- a/printing/printing_context_android.cc

+++ b/printing/printing_context_android.cc

@@ -91,7 +91,6 @@ void PrintingContextAndroid::AskUserForSettings(

if (j_printing_context_.is_null()) {

j_printing_context_.Reset(Java_PrintingContext_create(

env,

- base::android::GetApplicationContext(),

reinterpret_cast<int>(this)));

}