Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

Issue 63483007: Refactor Android printing code to make it more testable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved isPrintingController into PrintingControllerImpl, cleaned tiny bits Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
index 75cfa085d154f91f69e4b9c11caafa06664d97e2..da819a5ca50be46b996ed9a70dca35f8439f49ab 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
@@ -322,6 +322,12 @@ public abstract class TabBase implements NavigationClient {
*/
protected abstract AutoLoginProcessor createAutoLoginProcessor();
+ /** Prints the current page. */
whywhat 2013/11/19 15:39:32 nit: Should be the multiline comment, add a @retur
cimamoglu1 2013/11/19 17:40:33 Done.
+ public boolean print() {
+ assert mNativeTabAndroid != 0;
+ return nativePrint(mNativeTabAndroid);
+ }
+
/**
* Reloads the current page content if it is a {@link ContentView}.
*/
@@ -771,4 +777,5 @@ public abstract class TabBase implements NavigationClient {
private native int nativeGetSecurityLevel(int nativeTabAndroid);
private native void nativeSetActiveNavigationEntryTitleForUrl(int nativeTabAndroid, String url,
String title);
+ private native boolean nativePrint(int nativeTabAndroid);
}

Powered by Google App Engine
This is Rietveld 408576698