Source/core/loader/FrameLoaderClient.h - Issue 634813002: [ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [1/3 blink]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 634813002: [ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [1/3 blink] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoaderClient.h

diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h

index 2afebccfb72e4a34a1239fb10c00c7b8b08a3ef2..e52d0d9d2e6f28235ddb5223d5da967831eb5ee3 100644

--- a/Source/core/loader/FrameLoaderClient.h

+++ b/Source/core/loader/FrameLoaderClient.h

@@ -206,7 +206,7 @@ namespace blink {

virtual PassOwnPtr<blink::WebServiceWorkerProvider> createServiceWorkerProvider() = 0;

- virtual bool isControlledByServiceWorker() = 0;

+ virtual bool isControlledByServiceWorker(DocumentLoader*) = 0;

tkent 2014/10/07 23:58:56 nit: If the argument is always non-null, please ch

horo 2014/10/08 01:33:41 Done.

virtual SharedWorkerRepositoryClient* sharedWorkerRepositoryClient() { return 0; }

« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »