public/web/WebFrameClient.h - Issue 634813002: [ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [1/3 blink]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrameClient.h

Issue 634813002: [ServiceWorker] Add WebDataSource argument to isControlledByServiceWorker() [1/3 blink] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index 6d41edb216849273b1de60f3eff08131b9e0496e..53dffcc4e5572928de462980152d2fd4e86fd283 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -570,7 +570,9 @@ public:

// ServiceWorker -------------------------------------------------------

// Whether the frame is controlled by the ServiceWorker

michaeln 2014/10/07 19:28:24 Maybe for clarity alter the comment to read 'Wheth

horo 2014/10/07 22:47:31 Done.

+ // FIXME: Remove isControlledByServiceWorker().

virtual bool isControlledByServiceWorker() { return false; }

+ virtual bool isControlledByServiceWorker(WebDataSource*) { return false; }

protected:

virtual ~WebFrameClient() { }

« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | no next file » | no next file with comments »