Make host port availability detection more robust.

Make host port availability detection more robust.

Previously, it only detected ports that were bound to *, localhost or
127.0.0.1. This detects ports bound to any interface. I noticed this
while investigating 294878, and it could certainly be a source of
flake, but I don't think it's the main one.

BUG=294878
Committed: https://crrev.com/da7e64810f0305512cd20f0301c2ac1b21d8bc70
Cr-Commit-Position: refs/heads/master@{#299379}

[tonyg, 2014-10-07 01:34:17]

tonyg@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2014-10-07 08:37:09]

lgtm w/ nits

You need to change the call to IsHostPortUsed in
b/a/pylib/chrome_test_server_spawner.py

https://codereview.chromium.org/634803002/diff/1/build/android/pylib/ports.py
File build/android/pylib/ports.py (right):

https://codereview.chromium.org/634803002/diff/1/build/android/pylib/ports.py...
build/android/pylib/ports.py:92: s.bind(('', host_port))
nit: I'd rather we explicitly close the socket if we don't throw an exception
here instead of waiting for GC to take care of it, especially since we'll be
using the port.

[tonyg, 2014-10-07 16:25:26]

> You need to change the call to IsHostPortUsed in
> b/a/pylib/chrome_test_server_spawner.py

Thanks, good catch. I tried to make the callsites there more readable as well.

> nit: I'd rather we explicitly close the socket if we don't throw an exception
> here instead of waiting for GC to take care of it, especially since we'll be
> using the port.

Oops! Total mistake, fixed.

[tonyg, 2014-10-07 16:25:31]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-10-07 16:27:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634803002/20001

[commit-bot: I haz the power, 2014-10-07 18:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-07 18:34:49]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[tonyg, 2014-10-13 21:01:18]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-10-13 21:02:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634803002/40001

[commit-bot: I haz the power, 2014-10-13 22:33:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-13 22:34:16]

Patchset 3 (id:??) landed as
https://crrev.com/da7e64810f0305512cd20f0301c2ac1b21d8bc70
Cr-Commit-Position: refs/heads/master@{#299379}