Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 63473002: Have FontFallbackList::primaryFontData always return font data (Closed)

Created:
7 years, 1 month ago by eae
Modified:
7 years ago
CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, Stephen Chennney, pdr.
Visibility:
Public.

Description

Have FontFallbackList::primaryFontData always return font data The current implementation of FontFallbackList::primaryFontData can return NULL in certain cases however the majority of callers assumes that it never does. Change the implementation to return the last resort fallback if no other suitable font can be found. This is a speculative fix for the top linux crash report. BUG=314128 R=schenney@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/platform/graphics/FontFallbackList.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eae
7 years, 1 month ago (2013-11-06 23:51:09 UTC) #1
eae
7 years, 1 month ago (2013-11-06 23:59:35 UTC) #2
dglazkov
7 years, 1 month ago (2013-11-07 18:15:05 UTC) #3
lgtm. I think not ever returning 0 is reasonable (maybe it should return a
reference or something?). I have no clue whether
getNonRetainedLastResortFallbackFont is the right thing to return though.
Doesn't hurt to try, right? :)

Powered by Google App Engine
This is Rietveld 408576698