Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: mojo/services/public/interfaces/network/network_service.mojom

Issue 634713002: Implement parts of the Mojo TCP interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/network/network_service.mojom
diff --git a/mojo/services/public/interfaces/network/network_service.mojom b/mojo/services/public/interfaces/network/network_service.mojom
index 78841448dccf895b4725ab2c5c117aa415a2202f..8a49797d3ffd59f7f2fd124fe7479c9b227662e7 100644
--- a/mojo/services/public/interfaces/network/network_service.mojom
+++ b/mojo/services/public/interfaces/network/network_service.mojom
@@ -6,7 +6,7 @@ import "mojo/services/public/interfaces/network/cookie_store.mojom"
import "mojo/services/public/interfaces/network/net_address.mojom"
import "mojo/services/public/interfaces/network/network_error.mojom"
import "mojo/services/public/interfaces/network/tcp_bound_socket.mojom"
-import "mojo/services/public/interfaces/network/tcp_client_socket.mojom"
+import "mojo/services/public/interfaces/network/tcp_connected_socket.mojom"
import "mojo/services/public/interfaces/network/url_loader.mojom"
import "mojo/services/public/interfaces/network/web_socket.mojom"
@@ -27,14 +27,14 @@ interface NetworkService {
//
// If you want to create a client socket to connect to a server and are in
// the common case where you don't care about the local address it's bound
- // to, use CreateTCPClientSocket.
+ // to, use CreateTCPConnectedSocket.
//
// The local address can specify 0 for the port to specify that the OS should
// pick an available port for the given address, or it can pass 0 for the
// address and port for the OS to pick both the local address and port. In
// all success cases, the resulting local address will be passed to the
// callback as bound_to.
- CreateTCPBoundSocket(NetAddress local_address,
+ CreateTCPBoundSocket(NetAddress? local_address,
TCPBoundSocket& bound_socket)
=> (NetworkError result, NetAddress? bound_to);
@@ -44,10 +44,10 @@ interface NetworkService {
//
// If you want control over the local address and port, instead use
// CreateTCPBoundSocket.
- CreateTCPClientSocket(NetAddress remote_address,
- handle<data_pipe_consumer> send_stream,
- handle<data_pipe_producer> receive_stream,
- TCPClientSocket& client_socket)
+ CreateTCPConnectedSocket(NetAddress remote_address,
+ handle<data_pipe_consumer> send_stream,
+ handle<data_pipe_producer> receive_stream,
+ TCPConnectedSocket& client_socket)
=> (NetworkError result,
NetAddress? local_address);
};

Powered by Google App Engine
This is Rietveld 408576698