crosh: Permit SSH-ing to IPv6 addresses.

crosh: Permit SSH-ing to IPv6 addresses.

Change-Id: I0d95c7fa317cb7f41db01ade26eb415319dc50b7

BUG=chromium-os:11211
TEST=tried it with ":1", "::1", various IPv4 and IPv6 addresses, hostnames, and bogus values

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f149298

[Aaron Plattner, 2011-01-28 06:01:14]

This isn't quite sufficient, because IPv6 addresses can end in a traditional
dotted quad.  For example, you should also be able to do this:

Welcome to crosh, type 'help' for a list of commands.
crosh> ssh aaron ::ffff:127.0.0.1
open: host: ::ffff:127.0.0.1, user: aaron, port: 22
The authenticity of host '::ffff:127.0.0.1 (::ffff:127.0.0.1)' can't be
established.
RSA key fingerprint is 87:09:0c:f6:0c:5a:0d:9a:c9:aa:db:e7:9c:8e:2d:3d.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '::ffff:127.0.0.1' (RSA) to the list of known hosts.
Linux praxis 2.6.35-24-generic #42-Ubuntu SMP Thu Dec 2 02:41:37 UTC 2010 x86_64
GNU/Linux
Ubuntu 10.10

Welcome to Ubuntu!
 * Documentation:  https://help.ubuntu.com/

Last login: Thu Jan 27 11:16:06 2011 from tegra
aaron@praxis:~$

[Daniel Erat, 2011-01-28 17:56:09]

On 2011/01/28 06:01:14, Aaron Plattner wrote:
> This isn't quite sufficient, because IPv6 addresses can end in a traditional
> dotted quad.  For example, you should also be able to do this:
[snip]

Thanks; shows how ready I am for the future. :-/

I've added '.' to the character class.  Do you need zone indices as well, or is
that overkill?

[Aaron Plattner, 2011-01-28 19:55:58]

On 2011/01/28 17:56:09, Daniel Erat wrote:
> Do you need zone indices as well, or is
> that overkill?

That's a good point, zone indices are necessary for link-local addresses.

[Daniel Erat, 2011-01-28 22:36:53]

Updated to permit zone indices and to get rid of the call to 'reset'.

http://codereview.chromium.org/6347023/diff/12001/bin/crosh
File bin/crosh (left):

http://codereview.chromium.org/6347023/diff/12001/bin/crosh#oldcode26
bin/crosh:26: reset
This shouldn't be needed now that we're using rxvt-unicode instead of aterm or
xterm.

http://codereview.chromium.org/6347023/diff/12001/bin/crosh
File bin/crosh (right):

http://codereview.chromium.org/6347023/diff/12001/bin/crosh#newcode461
bin/crosh:461: echo "$1" | /bin/grep -E -q '^[0-9a-fA-F:.]+(%[a-z0-9]+)?$'
I finally gave up on expr's poorly-documented regular expression syntax and
switched to grep -E.  Let me know if you think this will cause problems -- I'm
happy to switch back to expr if you can suggest a roughly equivalent regexp, but
nothing that I tried worked:

  ^[0-9a-fA-F:.]\{1,\}\(%[[:alnum:]]\{1,\}\)\?$

[rginda, 2011-02-02 23:07:42]

lgtm, thanks for doing this!

http://codereview.chromium.org/6347023/diff/12001/bin/crosh
File bin/crosh (left):

http://codereview.chromium.org/6347023/diff/12001/bin/crosh#oldcode26
bin/crosh:26: reset
On 2011/01/28 22:36:53, Daniel Erat wrote:
> This shouldn't be needed now that we're using rxvt-unicode instead of aterm or
> xterm.

Cool, that reset took forever.