Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 634683002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/ This patch was generated by running the rewrite_scoped_refptr clang tool on an Android build. BUG=110610 Committed: https://crrev.com/9fdc1ea5e9111d3594d4c25c1266764d5925d7c4 Cr-Commit-Position: refs/heads/master@{#298346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/android/intercept_download_resource_throttle.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
6 years, 2 months ago (2014-10-06 22:41:41 UTC) #2
nyquist
lgtm
6 years, 2 months ago (2014-10-06 22:43:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634683002/1
6 years, 2 months ago (2014-10-06 23:10:46 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 01:42:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634683002/1
6 years, 2 months ago (2014-10-07 01:49:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3da38c29d15c13f207c6baa27f15f53a385ad2d9
6 years, 2 months ago (2014-10-07 03:16:25 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 03:17:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fdc1ea5e9111d3594d4c25c1266764d5925d7c4
Cr-Commit-Position: refs/heads/master@{#298346}

Powered by Google App Engine
This is Rietveld 408576698