Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/test/services/completion/local_computer_test.dart

Issue 634653002: add named constructor, cascade selector suggestions and more tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/local_computer_test.dart
diff --git a/pkg/analysis_server/test/services/completion/local_computer_test.dart b/pkg/analysis_server/test/services/completion/local_computer_test.dart
index 8c7a446cb14250ef4063c6cbaf1449679a0ed61f..c504763741993518e3b72e747d971b515c9560fb 100644
--- a/pkg/analysis_server/test/services/completion/local_computer_test.dart
+++ b/pkg/analysis_server/test/services/completion/local_computer_test.dart
@@ -155,20 +155,6 @@ class LocalComputerTest extends AbstractCompletionTest {
assertSuggestParameter('b', 'R');
}
- test_InstanceCreationExpression() {
- // SimpleIdentifier TypeName ConstructorName InstanceCreationExpression
- addTestSource('class A {a() {var f; {var x;} new ^}} class B { }');
- expect(computeFast(), isTrue);
- assertSuggestClass('A');
- assertSuggestClass('B');
- // TODO (danrubel) should only suggest types
- //assertNotSuggested('a');
- assertSuggestMethod('a', 'A', null);
- //assertNotSuggested('f');
- assertSuggestLocalVariable('f', null);
- assertNotSuggested('x');
- }
-
test_InterpolationExpression() {
// SimpleIdentifier InterpolationExpression StringInterpolation
addTestSource('main() {String name; print("hello \$^");}');
@@ -298,4 +284,74 @@ class LocalComputerTest extends AbstractCompletionTest {
assertNotSuggested('g');
assertNotSuggested('x');
}
+
+ //TODO (danrubel) implement
+ xtest_ConstructorName_importedClass() {
+ // SimpleIdentifier PrefixedIdentifier TypeName ConstructorName
+ // InstanceCreationExpression
+ addSource('/testB.dart', '''
+ lib B;
+ class X {X.c(); X._d(); z() {}}''');
+ addTestSource('''
+ import "/testB.dart";
+ var m;
+ main() {new X.^}''');
+ return computeFull().then((_) {
+ assertNoSuggestions();
+ });
+ }
+
+ //TODO (danrubel) implement
+ xtest_ConstructorName_localClass() {
+ // SimpleIdentifier PrefixedIdentifier TypeName ConstructorName
+ // InstanceCreationExpression
+ addTestSource('''
+ var m;
+ class X {X.c(); X._d(); z() {}}
+ main() {new X.^}''');
+ return computeFull().then((_) {
+ assertNoSuggestions();
+ });
+ }
+
+ //TODO (danrubel) implement
+ xtest_InstanceCreationExpression() {
+ // SimpleIdentifier TypeName ConstructorName InstanceCreationExpression
+ addTestSource('class A {a() {var f; {var x;} new ^}} class B { }');
+ expect(computeFast(), isTrue);
+ assertSuggestClass('A');
+ assertSuggestClass('B');
+ assertNotSuggested('a');
+ assertNotSuggested('f');
+ assertNotSuggested('x');
+ }
+
+ //TODO (danrubel) implement
+ xtest_IsExpression_imported() {
+ // SimpleIdentifier TypeName IsExpression IfStatement
+ addSource('/testB.dart', '''
+ lib B;
+ class X {X.c(); X._d(); z() {}}''');
+ addTestSource('''
+ import "/testB.dart";
+ main() {var x; if (x is ^) { }}''');
+ return computeFull().then((_) {
+ assertNoSuggestions();
+ });
+ }
+
+ //TODO (danrubel) implement
+ xtest_IsExpression_local() {
+ // SimpleIdentifier TypeName IsExpression IfStatement
+ addTestSource('''
+ class X {X.c(); X._d(); z() {}}
+ main() {var x; if (x is ^) { }}''');
+ return computeFull().then((_) {
+ assertSuggestConstructor('c');
+ assertNotSuggested('main');
+ assertNotSuggested('X');
+ assertNotSuggested('B');
+ assertNotSuggested('x');
+ });
+ }
}

Powered by Google App Engine
This is Rietveld 408576698