Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: runtime/vm/object.cc

Issue 634603002: Await always waits (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 41084)
+++ runtime/vm/object.cc (working copy)
@@ -1457,6 +1457,8 @@
CLASS_LIST_WITH_NULL(ADD_SET_FIELD)
#undef ADD_SET_FIELD
+ object_store->InitAsyncObjects();
+
return Error::null();
}
@@ -5498,6 +5500,12 @@
// Native methods don't need to be optimized.
return false;
}
+ if (is_async_closure()) {
+ // TODO(hausner|fschneider): A suspected bug in the load elimination
+ // optimizer causes some async closures to fail. Until that bug is
+ // fixed, do not optimize async closures.
+ return false;
+ }
if (is_optimizable() && (script() != Script::null()) &&
((end_token_pos() - token_pos()) < FLAG_huge_method_cutoff_in_tokens)) {
// Additional check needed for implicit getters.

Powered by Google App Engine
This is Rietveld 408576698