Issue 634593002: Move remove(All)Client(s)FromCache to RenderSVGResourceContainer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 634593002: Move remove(All)Client(s)FromCache to RenderSVGResourceContainer (Closed)

Created:
6 years, 2 months ago by fs

Modified:
6 years, 2 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Move remove(All)Client(s)FromCache to RenderSVGResourceContainer These methods are never called on something that is only RenderSVGResource. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183299

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -6 lines)			Patch
M	Source/core/rendering/svg/RenderSVGResource.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceContainer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceSolidColor.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634593002/1

6 years, 2 months ago (2014-10-07 02:44:01 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-07 03:24:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183299

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages