Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 634593002: Move remove(All)Client(s)FromCache to RenderSVGResourceContainer (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Move remove(All)Client(s)FromCache to RenderSVGResourceContainer These methods are never called on something that is only RenderSVGResource. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
6 years, 2 months ago (2014-10-06 16:11:31 UTC) #2
pdr.
On 2014/10/06 at 16:11:31, fs wrote: > LGTM
6 years, 2 months ago (2014-10-07 02:42:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634593002/1
6 years, 2 months ago (2014-10-07 02:44:01 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 03:24:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183299

Powered by Google App Engine
This is Rietveld 408576698