android_webview/browser/hardware_renderer.cc - Issue 634583004: Remove implicit conversions from scoped_refptr to T* in android_webview/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 634583004: Remove implicit conversions from scoped_refptr to T* in android_webview/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/deferred_gpu_command_service.cc ('k') | android_webview/browser/net/aw_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/hardware_renderer.cc

diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc

index 20743ec646a9b5a73f060b19a25e3dfb98f824c8..c4611d2dbe61f21444425c9bcb33bf33433058db 100644

--- a/android_webview/browser/hardware_renderer.cc

+++ b/android_webview/browser/hardware_renderer.cc

@@ -174,8 +174,8 @@ void HardwareRenderer::SetFrameData() {

frame_size_ = frame_size;

scroll_offset_ = input->scroll_offset;

- if (!frame_provider_ || size_changed) {

- if (delegated_layer_) {

+ if (!frame_provider_.get() || size_changed) {

+ if (delegated_layer_.get()) {

delegated_layer_->RemoveFromParent();

}