chrome/browser/memory_details_win.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory_details_win.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/memory_details_win.cc

diff --git a/chrome/browser/memory_details_win.cc b/chrome/browser/memory_details_win.cc

index 1b9ed4f0ddb708cc55cde9d4af5472d06d337360..b580cd585e554ba88ba8afdc654fb8d0bf524789 100644

--- a/chrome/browser/memory_details_win.cc

+++ b/chrome/browser/memory_details_win.cc

@@ -124,8 +124,7 @@ void MemoryDetails::CollectProcessData(

TCHAR name[MAX_PATH];

if (index2 == CHROME_BROWSER || index2 == CHROME_NACL_PROCESS) {

chrome::VersionInfo version_info;

- if (version_info.is_valid())

- info.version = base::ASCIIToWide(version_info.Version());

+ info.version = base::ASCIIToWide(version_info.Version());

// Check if this is one of the child processes whose data we collected

// on the IO thread, and if so copy over that data.

for (size_t child = 0; child < child_info.size(); child++) {

« no previous file with comments | « chrome/browser/memory_details_mac.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »