chrome/browser/extensions/updater/extension_downloader.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_downloader.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: linux include Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/updater/extension_downloader.cc

diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc

index 4918dfc854b8a72599163ee4e0f610fe099e1b58..93cb40d7d66d762a083620e64990db9470e17701 100644

--- a/chrome/browser/extensions/updater/extension_downloader.cc

+++ b/chrome/browser/extensions/updater/extension_downloader.cc

@@ -672,8 +672,7 @@ void ExtensionDownloader::DetermineUpdates(

// First determine the browser version if we haven't already.

if (!browser_version.IsValid()) {

chrome::VersionInfo version_info;

- if (version_info.is_valid())

- browser_version = Version(version_info.Version());

+ browser_version = Version(version_info.Version());

}

Version browser_min_version(update->browser_min_version);

if (browser_version.IsValid() && browser_min_version.IsValid() &&

« no previous file with comments | « chrome/browser/diagnostics/recon_diagnostics.cc ('k') | chrome/browser/memory_details_mac.cc » ('j') | no next file with comments »