chrome/browser/sync/glue/local_device_info_provider_impl.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/local_device_info_provider_impl.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/glue/local_device_info_provider_impl.cc

diff --git a/chrome/browser/sync/glue/local_device_info_provider_impl.cc b/chrome/browser/sync/glue/local_device_info_provider_impl.cc

index bc8e14a35801d58a6ee7376250d0ab0433f57f28..bd6a18f68fb9ce9490508788f3f502ab6976e87b 100644

--- a/chrome/browser/sync/glue/local_device_info_provider_impl.cc

+++ b/chrome/browser/sync/glue/local_device_info_provider_impl.cc

@@ -87,11 +87,6 @@ std::string LocalDeviceInfoProviderImpl::MakeUserAgentForSyncApi(

#elif defined(OS_MACOSX)

user_agent += "MAC ";

#endif

- if (!version_info.is_valid()) {

- DLOG(ERROR) << "Unable to create chrome::VersionInfo object";

- return user_agent;

- }

user_agent += version_info.Version();

user_agent += " (" + version_info.LastChange() + ")";

if (!version_info.IsOfficialBuild()) {

« chrome/browser/diagnostics/recon_diagnostics.cc ('K') | « chrome/browser/sync/about_sync_util.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »