Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: chrome/browser/metrics/variations/variations_service.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.cc
diff --git a/chrome/browser/metrics/variations/variations_service.cc b/chrome/browser/metrics/variations/variations_service.cc
index 2bc0786979cd1577ad03ac6e9578301038456689..d25c0de018316846984c28287788bded3425fb42 100644
--- a/chrome/browser/metrics/variations/variations_service.cc
+++ b/chrome/browser/metrics/variations/variations_service.cc
@@ -259,9 +259,6 @@ bool VariationsService::CreateTrialsFromSeed() {
return false;
const chrome::VersionInfo current_version_info;
- if (!current_version_info.is_valid())
- return false;
-
const base::Version current_version(current_version_info.Version());
if (!current_version.IsValid())
return false;

Powered by Google App Engine
This is Rietveld 408576698