Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5647)

Unified Diff: chrome/browser/memory_details_mac.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/memory_details_mac.cc
diff --git a/chrome/browser/memory_details_mac.cc b/chrome/browser/memory_details_mac.cc
index 2b1bf07d48c6c063fd584fba6f5a42b51d687ac7..f63635a85c20d671c20f1e560855896bfe3d9876 100644
--- a/chrome/browser/memory_details_mac.cc
+++ b/chrome/browser/memory_details_mac.cc
@@ -215,13 +215,8 @@ void MemoryDetails::CollectProcessDataChrome(
info.process_type = content::PROCESS_TYPE_UNKNOWN;
chrome::VersionInfo version_info;
- if (version_info.is_valid()) {
- info.product_name = base::ASCIIToUTF16(version_info.Name());
- info.version = base::ASCIIToUTF16(version_info.Version());
- } else {
- info.product_name = process_data_[CHROME_BROWSER].name;
- info.version = base::string16();
- }
+ info.product_name = base::ASCIIToUTF16(version_info.Name());
+ info.version = base::ASCIIToUTF16(version_info.Version());
// Check if this is one of the child processes whose data we collected
// on the IO thread, and if so copy over that data.

Powered by Google App Engine
This is Rietveld 408576698