chrome/browser/diagnostics/recon_diagnostics.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/recon_diagnostics.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/drive_integration_service.cc ('k') | chrome/browser/extensions/updater/extension_downloader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/diagnostics/recon_diagnostics.cc

diff --git a/chrome/browser/diagnostics/recon_diagnostics.cc b/chrome/browser/diagnostics/recon_diagnostics.cc

index 0375577978285b8c8e0856b7756d76dea4165943..20cbb437881d52b489d8eadd68f0d0717d3ced6e 100644

--- a/chrome/browser/diagnostics/recon_diagnostics.cc

+++ b/chrome/browser/diagnostics/recon_diagnostics.cc

@@ -359,10 +359,6 @@ class VersionTest : public DiagnosticsTest {

virtual bool ExecuteImpl(DiagnosticsModel::Observer* observer) OVERRIDE {

chrome::VersionInfo version_info;

- if (!version_info.is_valid()) {

- RecordFailure(DIAG_RECON_NO_VERSION, "No Version");

Lei Zhang 2014/10/06 19:22:52 DIAG_RECON_NO_VERSION is no longer used, but I'm n

cpu_(ooo_6.6-7.5) 2014/10/06 19:27:43 This might be used by CroS. Sad times.

- return true;

- }

std::string current_version = version_info.Version();

if (current_version.empty()) {

RecordFailure(DIAG_RECON_EMPTY_VERSION, "Empty Version");