chrome/browser/chromeos/drive/drive_integration_service.cc - Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/drive_integration_service.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/drive/drive_integration_service.cc

diff --git a/chrome/browser/chromeos/drive/drive_integration_service.cc b/chrome/browser/chromeos/drive/drive_integration_service.cc

index f0f771710d520c84c57ee687627ff3175b04b335..f786c9cc4ddbf112c493c1442bb46cf5209c28c4 100644

--- a/chrome/browser/chromeos/drive/drive_integration_service.cc

+++ b/chrome/browser/chromeos/drive/drive_integration_service.cc

@@ -78,9 +78,7 @@ std::string GetDriveUserAgent() {

const char kDriveClientName[] = "chromedrive";

chrome::VersionInfo version_info;

- const std::string version = (version_info.is_valid() ?

- version_info.Version() :

- std::string("unknown"));

+ const std::string version = version_info.Version();

// This part is <client_name>/<version>.

const char kLibraryInfo[] = "chrome-cc/none";

« no previous file with comments | « no previous file | chrome/browser/diagnostics/recon_diagnostics.cc » ('j') | chrome/browser/diagnostics/recon_diagnostics.cc » ('J')