Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/cloud_print/cloud_print_helpers.cc

Issue 634583003: Simplify VersionInfo code, avoid hitting sandbox IPC constantly on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mac, cros Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/chrome_version_info_values.h.version ('K') | « chrome/common/chrome_version_info_values.h.version ('k') | chrome/common/service_process_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/cloud_print/cloud_print_helpers.cc
diff --git a/chrome/common/cloud_print/cloud_print_helpers.cc b/chrome/common/cloud_print/cloud_print_helpers.cc
index 2681c505786946c594c4e3ac22cd4162ddfba425..ff1eaeb786fe102439d085c2157482fe7377dcc9 100644
--- a/chrome/common/cloud_print/cloud_print_helpers.cc
+++ b/chrome/common/cloud_print/cloud_print_helpers.cc
@@ -26,7 +26,6 @@ namespace {
PrinterTags PreparePrinterTags(const PrinterTags& printer_tags) {
PrinterTags printer_tags_out = printer_tags;
chrome::VersionInfo version_info;
- DCHECK(version_info.is_valid());
printer_tags_out[kChromeVersionTagName] =
version_info.CreateVersionString();
printer_tags_out[kSystemNameTagName] =
« chrome/common/chrome_version_info_values.h.version ('K') | « chrome/common/chrome_version_info_values.h.version ('k') | chrome/common/service_process_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698