Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634543002: DevTools: NetworkPanel: update hovered row labels when graph is updated. (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
vsevik, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: NetworkPanel: update hovered row labels when graph is updated. BUG=419676 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183656

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M Source/devtools/front_end/network/NetworkPanel.js View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
eustas
6 years, 2 months ago (2014-10-06 12:38:47 UTC) #2
eustas
6 years, 2 months ago (2014-10-07 05:13:56 UTC) #4
vsevik
lgtm https://codereview.chromium.org/634543002/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/634543002/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode2729 Source/devtools/front_end/network/NetworkPanel.js:2729: this._parentView.__hoveredRow = this; Let's use Symbol
6 years, 2 months ago (2014-10-14 06:48:08 UTC) #5
eustas
https://codereview.chromium.org/634543002/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/634543002/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode2729 Source/devtools/front_end/network/NetworkPanel.js:2729: this._parentView.__hoveredRow = this; On 2014/10/14 06:48:08, vsevik wrote: > ...
6 years, 2 months ago (2014-10-14 08:17:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543002/20001
6 years, 2 months ago (2014-10-14 08:18:50 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 09:23:45 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183656

Powered by Google App Engine
This is Rietveld 408576698