Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634533003: Replace OVERRIDE and FINAL with override and final in content/browser/accessibility/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/browser/accessibility/[a-s]* BUG=417463 Committed: https://crrev.com/dbd9edd9140af6c9cdbbfd96eb03d54068a96f0f Cr-Commit-Position: refs/heads/master@{#298473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M content/browser/accessibility/browser_accessibility_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Anand Ratn (left samsung)
sky@chromium.org: Please review changes in content/browser/accessibility jochen@chromium.org: Please review changes in content/browser/accessibility
6 years, 2 months ago (2014-10-06 14:22:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-07 10:00:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634533003/1
6 years, 2 months ago (2014-10-07 11:00:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/21076)
6 years, 2 months ago (2014-10-07 12:38:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634533003/1
6 years, 2 months ago (2014-10-07 14:00:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5f11ccee12d2d7cc4b5bd8dbf6eb4fb9e9cee94e
6 years, 2 months ago (2014-10-07 14:36:19 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:36:56 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dbd9edd9140af6c9cdbbfd96eb03d54068a96f0f
Cr-Commit-Position: refs/heads/master@{#298473}

Powered by Google App Engine
This is Rietveld 408576698