Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu …

content/test/data/accessibility/input-button-in-menu-expected-android.txt

Index: content/test/data/accessibility/input-button-in-menu-expected-android.txt
diff --git a/content/test/data/accessibility/input-button-in-menu-expected-android.txt b/content/test/data/accessibility/input-button-in-menu-expected-android.txt
index 3c2356be92f29ef50e08c33ffaeecefe5896532b..8f9fe372664b75489d98e2ae22e9cba6f01c3fa4 100644
--- a/content/test/data/accessibility/input-button-in-menu-expected-android.txt
+++ b/content/test/data/accessibility/input-button-in-menu-expected-android.txt
@@ -1,6 +1,5 @@
-#<skip -- Need to generate correct expectations>
 android.webkit.WebView focusable focused scrollable
     android.view.View
-        android.widget.Button clickable focusable name='Button in menu element'
+        android.view.View clickable focusable name='Button in menu element'

[Mike West, 2014/10/14 11:17:49]

Is this accurate? "Button" seemed like a better representation.

[shreeramk, 2014/10/14 11:32:41]

For button with menu as parent, defined role is ROLE_SYSTEM_MENUITEM.

And for input type button, blink returns MenuItemRole(existing role in blink),
so for android adding that case here 

case ui::AX_ROLE_BUTTON:
case ui::AX_ROLE_MENU_BUTTON:
case ui::AX_ROLE_POP_UP_BUTTON:
    class_name = "android.widget.Button";
    break;

to get android.widget.Button will lead all menuitem types to
android.widget.Button

OR

MenuButtonRole can be used. which corresponds with AX_ROLE_MENU_BUTTON in
chromium side.

[dmazzoni, 2014/10/14 15:20:04]

You can use any class name from the Android widget hierarchy here -
http://developer.android.com/reference/android/view/MenuItem.html - so perhaps "
android.view.MenuItem"

Without testing on Android I don't know for sure what would be best, but I agree
with Mike that an interactive element should be a Button or MenuItem or some
interactive widget role, as opposed to just android.view.View.

     android.view.View
-        android.widget.Button clickable focusable name='Button in element with menu role'
+        android.view.View clickable focusable name='Button in element with menu role'