content/browser/accessibility/browser_accessibility_android.cc - Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporating comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_win.cc » ('j') | content/browser/accessibility/browser_accessibility_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index dd1511d58de3308a89c7205f89997b717e649211..9decb8ac709b90eeffc999221089349b7bc2431e 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -230,9 +230,11 @@ const char* BrowserAccessibilityAndroid::GetClassName() const {

class_name = "android.widget.Button";

break;

case ui::AX_ROLE_CHECK_BOX:

+ case ui::AX_ROLE_MENU_ITEM_CHECK_BOX:

class_name = "android.widget.CheckBox";

break;

case ui::AX_ROLE_RADIO_BUTTON:

+ case ui::AX_ROLE_MENU_ITEM_RADIO:

class_name = "android.widget.RadioButton";

break;

case ui::AX_ROLE_TOGGLE_BUTTON:

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_win.cc » ('j') | content/browser/accessibility/browser_accessibility_win.cc » ('J')