content/browser/accessibility/browser_accessibility_win.cc - Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | content/test/data/accessibility/aria-menuitemradio-expected-android.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index e7b206c4fe6429a8fd91b05f7a09f20db461eaf0..6d8b38ec22756bd8a72f682a233293aec6169f28 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -3620,6 +3620,7 @@ void BrowserAccessibilityWin::InitRoleAndState() {

case ui::AX_ROLE_MENU_ITEM_CHECK_BOX:

ia_role_ = ROLE_SYSTEM_MENUITEM;

ia2_role_ = IA2_ROLE_CHECK_MENU_ITEM;

+ ia2_state_ |= IA2_STATE_CHECKABLE;

break;

case ui::AX_ROLE_MENU_ITEM_RADIO:

dmazzoni 2014/10/13 07:54:46 A radio should be checkable too. The html spec say

ia_role_ = ROLE_SYSTEM_MENUITEM;