content/test/data/accessibility/input-button-in-menu-expected-win.txt - Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/input-button-in-menu-expected-win.txt

Issue 634533002: Fixing IA2 role for input type attribute in button and checkbox state with menu and aria role menu … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing failure on win Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/accessibility/browser_accessibility_android.cc ('K') | « content/test/data/accessibility/input-button-in-menu-expected-android.txt ('k') | content/test/data/accessibility/input-checkbox-in-menu.html » ('j') | content/test/data/accessibility/input-checkbox-in-menu-expected-win.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #<skip - role not set correctly. http://crbug.com/169574>

2 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE	1 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE

3 IA2_ROLE_SECTION READONLY	2 IA2_ROLE_SECTION READONLY

4 ROLE_SYSTEM_MENUITEM name='Button in menu element' FOCUSABLE	3 ROLE_SYSTEM_MENUITEM name='Button in menu element' FOCUSABLE

5 ROLE_SYSTEM_MENUPOPUP	4 IA2_ROLE_SECTION READONLY

	5 ROLE_SYSTEM_STATICTEXT name='Button in menu element'

	6 ROLE_SYSTEM_MENUPOPUP xml-roles:menu

6 ROLE_SYSTEM_MENUITEM name='Button in element with menu role' FOCUSABLE	7 ROLE_SYSTEM_MENUITEM name='Button in element with menu role' FOCUSABLE
shreeramk 2014/10/08 17:53:34 Similarly here as well. Instead of exposing as RO Similarly here as well. Instead of exposing as ROLE_SYSTEM_MENUITEM, win_chromium_rel is exposing it as ROLE_SYSTEM_PUSHBUTTON.
	8 IA2_ROLE_SECTION READONLY

	9 ROLE_SYSTEM_STATICTEXT name='Button in element with menu role'

OLD	NEW