Allow copying of multiple bookmarks from within the bookmark manager.

components/bookmarks/browser/bookmark_node_data_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/browser/bookmark_node_data.h"
 #include "components/bookmarks/test/bookmark_test_helpers.h"
 #include "components/bookmarks/test/test_bookmark_client.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/clipboard/clipboard.h"
 #include "ui/base/dragdrop/os_exchange_data.h"
 #include "ui/events/platform/platform_event_source.h"
 #include "url/gurl.h"
 
 using base::ASCIIToUTF16;
 
 namespace bookmarks {
 
 class BookmarkNodeDataTest : public testing::Test {
  public:
   BookmarkNodeDataTest() {}
 
   virtual void SetUp() OVERRIDE {
     event_source_ = ui::PlatformEventSource::CreateDefault();
     model_ = client_.CreateModel();
     test::WaitForBookmarkModelToLoad(model_.get());
     bool success = profile_dir_.CreateUniqueTempDir();
     ASSERT_TRUE(success);
   }
 
   virtual void TearDown() OVERRIDE {
     model_.reset();
     event_source_.reset();
     bool success = profile_dir_.Delete();
     ASSERT_TRUE(success);
+    ui::Clipboard::DestroyClipboardForCurrentThread();
   }
 
   const base::FilePath& GetProfilePath() const { return profile_dir_.path(); }
 
   BookmarkModel* model() { return model_.get(); }
 
  private:
   base::ScopedTempDir profile_dir_;
   TestBookmarkClient client_;
   scoped_ptr<BookmarkModel> model_;
   scoped_ptr<ui::PlatformEventSource> event_source_;
+  base::MessageLoopForUI loop_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkNodeDataTest);
 };
 
 namespace {
 
 ui::OSExchangeData::Provider* CloneProvider(const ui::OSExchangeData& data) {
   return data.provider().Clone();
 }
 
@@ skipping 201 matching lines @@
       read_data.GetNodes(model(), GetProfilePath());
   ASSERT_EQ(2u, read_nodes.size());
   EXPECT_TRUE(read_nodes[0] == folder);
   EXPECT_TRUE(read_nodes[1] == url_node);
 
   // Asking for the first node should return NULL with more than one element
   // present.
   EXPECT_TRUE(read_data.GetFirstNode(model(), GetProfilePath()) == NULL);
 }
 
+TEST_F(BookmarkNodeDataTest, WriteToClipboardURL) {
+  BookmarkNodeData data;
+  GURL url(GURL("http://foo.com"));
+  const base::string16 title(ASCIIToUTF16("blah"));
+
+  // Write to clipboard

[sky, 2014/10/20 20:37:12]

nit: this comment here and in other places don't provide any value and can be
nuked.

[hichris123, 2014/10/20 23:12:59]

Done.

+  data.ReadFromTuple(url, title);
+  data.WriteToClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+
+  // Now read the data back in.
+  BookmarkNodeData read_data;
+  read_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+  ASSERT_EQ(1u, read_data.elements.size());
+  EXPECT_TRUE(read_data.elements[0].is_url);
+  EXPECT_EQ(url, read_data.elements[0].url);
+  EXPECT_EQ(title, read_data.elements[0].title);
+}
+
+TEST_F(BookmarkNodeDataTest, WriteToClipboardMultipleURLs) {
+  BookmarkNodeData data;
+  const BookmarkNode* root = model()->bookmark_bar_node();
+  GURL url(GURL("http://foo.com"));
+  const base::string16 title(ASCIIToUTF16("blah"));
+  GURL url2(GURL("http://bar.com"));
+  const base::string16 title2(ASCIIToUTF16("blah2"));
+  const BookmarkNode* url_node = model()->AddURL(root, 0, title, url);
+  const BookmarkNode* url_node2 = model()->AddURL(root, 1, title2, url2);
+  std::vector<const BookmarkNode*> nodes;
+  nodes.push_back(url_node);
+  nodes.push_back(url_node2);
+
+  // Write to clipboard
+  data.ReadFromVector(nodes);
+  data.WriteToClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+
+  // Now read the data back in.
+  BookmarkNodeData read_data;
+  read_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+  ASSERT_EQ(2u, read_data.elements.size());
+  EXPECT_TRUE(read_data.elements[0].is_url);
+  EXPECT_EQ(url, read_data.elements[0].url);
+  EXPECT_TRUE(read_data.elements[1].is_url);
+  EXPECT_EQ(url2, read_data.elements[1].url);
+}
+
+TEST_F(BookmarkNodeDataTest, WriteToClipboardEmptyFolder) {
+  BookmarkNodeData data;
+  const BookmarkNode* root = model()->bookmark_bar_node();
+  const BookmarkNode* folder = model()->AddFolder(root, 0, ASCIIToUTF16("g1"));
+  std::vector<const BookmarkNode*> nodes;
+  nodes.push_back(folder);
+
+  // Write to clipboard
+  data.ReadFromVector(nodes);
+  data.WriteToClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+
+  // Now read the data back in.
+  BookmarkNodeData read_data;
+  read_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+  ASSERT_EQ(1u, read_data.elements.size());
+  EXPECT_FALSE(read_data.elements[0].is_url);
+  EXPECT_EQ(ASCIIToUTF16("g1"), read_data.elements[0].title);
+}
+
+TEST_F(BookmarkNodeDataTest, WriteToClipboardFolderWithChildren) {
+  BookmarkNodeData data;
+  const BookmarkNode* root = model()->bookmark_bar_node();
+  const BookmarkNode* folder = model()->AddFolder(root, 0, ASCIIToUTF16("g1"));
+  GURL url(GURL("http://foo.com"));
+  const base::string16 title(ASCIIToUTF16("blah"));
+  const BookmarkNode* url_node = model()->AddURL(folder, 0, title, url);
+  std::vector<const BookmarkNode*> nodes;
+  nodes.push_back(folder);
+
+  // Write to clipboard
+  data.ReadFromVector(nodes);
+  data.WriteToClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+
+  // Now read the data back in.
+  BookmarkNodeData read_data;
+  read_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+  ASSERT_EQ(1u, read_data.elements.size());
+  EXPECT_FALSE(read_data.elements[0].is_url);
+  EXPECT_EQ(ASCIIToUTF16("g1"), read_data.elements[0].title);
+}
+
+TEST_F(BookmarkNodeDataTest, WriteToClipboardFolderAndURL) {

[sky, 2014/10/20 20:37:11]

Do any of these tests actually verify the code you're adding. AFAICT they all
verify existing code and would be better served in a separate cl.

[hichris123, 2014/10/20 20:41:12]

Only WriteToClipboardURL should be verifying existing code. The rest deal with
situations with folders or more than one URL and passing that to
WriteToClipboard, which is what I modified WriteToClipboard to handle.

+  BookmarkNodeData data;
+  GURL url(GURL("http://foo.com"));
+  const base::string16 title(ASCIIToUTF16("blah"));
+  const BookmarkNode* root = model()->bookmark_bar_node();
+  const BookmarkNode* url_node = model()->AddURL(root, 0, title, url);
+  const BookmarkNode* folder = model()->AddFolder(root, 0, ASCIIToUTF16("g1"));
+  std::vector<const BookmarkNode*> nodes;
+  nodes.push_back(url_node);
+  nodes.push_back(folder);
+
+  // Write to clipboard
+  data.ReadFromVector(nodes);
+  data.WriteToClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+
+  // Now read the data back in.
+  BookmarkNodeData read_data;
+  read_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE);
+  ASSERT_EQ(2u, read_data.elements.size());
+  EXPECT_TRUE(read_data.elements[0].is_url);
+  EXPECT_EQ(url, read_data.elements[0].url);
+  EXPECT_FALSE(read_data.elements[1].is_url);
+  EXPECT_EQ(ASCIIToUTF16("g1"), read_data.elements[1].title);
+}
+
 // Tests reading/writing of meta info.
 TEST_F(BookmarkNodeDataTest, MetaInfo) {
   // Create a node containing meta info.
   const BookmarkNode* node = model()->AddURL(model()->other_node(),
                                              0,
                                              ASCIIToUTF16("foo bar"),
                                              GURL("http://www.google.com"));
   model()->SetNodeMetaInfo(node, "somekey", "somevalue");
   model()->SetNodeMetaInfo(node, "someotherkey", "someothervalue");
 
   BookmarkNodeData node_data(node);
   ui::OSExchangeData data;
   node_data.Write(GetProfilePath(), &data);
 
   // Read the data back in.
   ui::OSExchangeData data2(CloneProvider(data));
   BookmarkNodeData read_data;
   EXPECT_TRUE(read_data.Read(data2));
   EXPECT_TRUE(read_data.is_valid());
   ASSERT_EQ(1u, read_data.elements.size());
 
   // Verify that the read data contains the same meta info.
   BookmarkNode::MetaInfoMap meta_info_map = read_data.elements[0].meta_info_map;
   EXPECT_EQ(2u, meta_info_map.size());
   EXPECT_EQ("somevalue", meta_info_map["somekey"]);
   EXPECT_EQ("someothervalue", meta_info_map["someotherkey"]);
 }
 
 }  // namespace bookmarks