Allow copying of multiple bookmarks from within the bookmark manager.

components/bookmarks/browser/bookmark_node_data.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bookmarks/browser/bookmark_node_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/pickle.h"
@@ skipping 160 matching lines @@
     // change fonts when such data is pasted in; besides, most such editors
     // auto-linkify at some point anyway.
 
     // Also write the URL to the clipboard as text so that it can be pasted
     // into text fields. We use WriteText instead of WriteURL because we don't
     // want to clobber the X clipboard when the user copies out of the omnibox
     // on Linux (on Windows and Mac, there is no difference between these
     // functions).
     scw.WriteText(base::UTF8ToUTF16(url));
   }
 

[sky, 2014/10/07 21:58:57]

See style guide for handling of else. Basically you want:
} else {

[hichris123, 2014/10/08 01:04:28]

Done.

+  // We have more than one element

[sky, 2014/10/07 21:58:57]

This comment isn't quite right.

[hichris123, 2014/10/08 01:04:28]

Done.

+  else {
+    bool all_urls = true;

[sky, 2014/10/07 21:58:57]

What's the rationale for this logic? Why ignore folders?

[hichris123, 2014/10/07 22:35:55]

I just tried not including folders, and it wouldn't copy & paste if a folder was
included. Is a folder not an Element? If it isn't, I could just loop through all
bookmarks in a folder, and copy that to the clipboard. Would that work?

[hichris123, 2014/10/08 01:04:29]

Done.

+    for (Element& element : elements) {
+      if (!element.is_url) {
+        all_urls = false;
+        break;
+      }
+    }
+
+    if (all_urls == true) {

[sky, 2014/10/07 21:58:57]

No == true here, just if (all_urls)

[hichris123, 2014/10/08 01:04:28]

Done.

+      std::string text;
+      for (size_t i = 0; i < elements.size(); i++) {
+        const std::string url = elements[i].url.spec();
+        text += i == 0 ? url : "\n" + url;
+      }
+      scw.WriteText(base::UTF8ToUTF16(text));
+    }
+  }
+
   Pickle pickle;
   WriteToPickle(base::FilePath(), &pickle);
   scw.WritePickledData(pickle,
                        ui::Clipboard::GetFormatType(kClipboardFormatString));
 }
 
 bool BookmarkNodeData::ReadFromClipboard(ui::ClipboardType type) {
   DCHECK_EQ(type, ui::CLIPBOARD_TYPE_COPY_PASTE);
   std::string data;
   ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
@@ skipping 88 matching lines @@
   profile_path_ = profile_path;
 }
 
 bool BookmarkNodeData::IsFromProfilePath(
     const base::FilePath& profile_path) const {
   // An empty path means the data is not associated with any profile.
   return !profile_path_.empty() && profile_path_ == profile_path;
 }
 
 }  // namespace bookmarks