Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 634493002: Make V8 compile with Win64 dbg (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M src/allocation.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-06 09:38:48 UTC) #1
dcarney
lgtm
6 years, 2 months ago (2014-10-06 10:14:21 UTC) #2
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-06 10:46:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698