Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 634483005: Replacing the OVERRIDE with override and FINAL with final in content/browser/[devtools/ssl] (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/[devtools/ssl] This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/d23d9adf5478bb45d70f37502c39462d439f609c Cr-Commit-Position: refs/heads/master@{#298387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -136 lines) Patch
M content/browser/devtools/devtools_agent_host_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/devtools/devtools_frontend_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 9 chunks +28 lines, -28 lines 0 comments Download
M content/browser/devtools/devtools_netlog_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_power_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_protocol.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_system_info_handler.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_agent_host.h View 1 chunk +11 lines, -11 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/devtools/ipc_devtools_agent_host.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 1 chunk +23 lines, -23 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/devtools/tethering_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_cert_error_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 03:44:53 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 03:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634483005/1
6 years, 2 months ago (2014-10-07 04:25:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 11deaf5da045df2f7743711cbea1639310e43491
6 years, 2 months ago (2014-10-07 05:49:23 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 05:50:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d23d9adf5478bb45d70f37502c39462d439f609c
Cr-Commit-Position: refs/heads/master@{#298387}

Powered by Google App Engine
This is Rietveld 408576698