Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 634433002: Fixed that the column header of file list placed incorrectly after double click on separator. (Closed)

Created:
6 years, 2 months ago by yawano
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed that the column header of file list placed incorrectly after double click on separator. This issue was caused by that while the columns were rendered with display:flex, splitters used (-webkit-)margin-start with column width in column_model to set their positions. When total width of columns exceeds width of a table, rendered width becomes different from width in column_model due to display:flex. Fixed this by keeping total width with calling setWidthAndKeepTotal instead of setWidth. BUG=408035 TEST=Narrow window so that at least file name is cropped; Double click the header's separator at the right side of Name column. Committed: https://crrev.com/bf6897a84c8a7f08e4c2cd8506b833d93a504ab8 Cr-Commit-Position: refs/heads/master@{#298206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 2 chunks +70 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
yawano
PTAL.
6 years, 2 months ago (2014-10-06 02:24:09 UTC) #2
fukino
On 2014/10/06 02:24:09, yawano wrote: > PTAL. Are all files uploaded? I couldn't find any ...
6 years, 2 months ago (2014-10-06 05:43:18 UTC) #3
fukino
On 2014/10/06 05:43:18, fukino wrote: > On 2014/10/06 02:24:09, yawano wrote: > > PTAL. > ...
6 years, 2 months ago (2014-10-06 05:44:58 UTC) #4
fukino
Could you provide a description? about: - What caused the problem. - How you fixed ...
6 years, 2 months ago (2014-10-06 06:01:25 UTC) #5
yawano
On 2014/10/06 06:01:25, fukino wrote: > Could you provide a description? about: > - What ...
6 years, 2 months ago (2014-10-06 06:14:14 UTC) #6
fukino
On 2014/10/06 06:14:14, yawano wrote: > On 2014/10/06 06:01:25, fukino wrote: > > Could you ...
6 years, 2 months ago (2014-10-06 06:54:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634433002/1
6 years, 2 months ago (2014-10-06 07:52:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as e1fd81d857200c80404d86ba52104bc43a99bcbd
6 years, 2 months ago (2014-10-06 09:14:49 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 09:15:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf6897a84c8a7f08e4c2cd8506b833d93a504ab8
Cr-Commit-Position: refs/heads/master@{#298206}

Powered by Google App Engine
This is Rietveld 408576698