app_list: Disable Drive app integration for M39.

app_list: Disable Drive app integration for M39.

BUG=421665
Committed: https://crrev.com/73d29fb89088780502fcae7b82a170c958cf5d8e
Cr-Commit-Position: refs/heads/master@{#299028}

[xiyuan, 2014-10-08 23:20:23]

xiyuan@chromium.org changed reviewers:
+ abodenha@chromium.org

[xiyuan, 2014-10-08 23:20:23]

The CL just disables the feature. The switch and flags are not changed (useless
now) because we will need them later.

[Albert Bodenhamer, 2014-10-08 23:25:59]

https://codereview.chromium.org/634413002/diff/1/ui/app_list/app_list_switche...
File ui/app_list/app_list_switches.cc (right):

https://codereview.chromium.org/634413002/diff/1/ui/app_list/app_list_switche...
ui/app_list/app_list_switches.cc:81: // Disable Drive app integration due to
http://crbug.com/420034
If we do it this way, the option will still show in about:flags, but wont do
anything.  I don't think we want that either.

Can't we just revert the change you landed that enabled it by default?

[xiyuan, 2014-10-09 01:14:15]

On 2014/10/08 23:25:59, Albert Bodenhamer wrote:
>
https://codereview.chromium.org/634413002/diff/1/ui/app_list/app_list_switche...
> File ui/app_list/app_list_switches.cc (right):
> 
>
https://codereview.chromium.org/634413002/diff/1/ui/app_list/app_list_switche...
> ui/app_list/app_list_switches.cc:81: // Disable Drive app integration due to
> http://crbug.com/420034
> If we do it this way, the option will still show in about:flags, but wont do
> anything.  I don't think we want that either.
> 
> Can't we just revert the change you landed that enabled it by default?

That would bring back the strings for the enable flag. Is that acceptable for
merging?
Otherwise,  how about removing the not functioning flag and its strings instead?

[Albert Bodenhamer, 2014-10-09 15:45:18]

Ah, right.

Yeah, let's just remove the flag.

On Wed Oct 08 2014 at 6:14:17 PM <xiyuan@chromium.org> wrote:

> On 2014/10/08 23:25:59, Albert Bodenhamer wrote:
>
> https://codereview.chromium.org/634413002/diff/1/ui/app_
> list/app_list_switches.cc
> > File ui/app_list/app_list_switches.cc (right):
>
>
> https://codereview.chromium.org/634413002/diff/1/ui/app_
> list/app_list_switches.cc#newcode81
> > ui/app_list/app_list_switches.cc:81: // Disable Drive app integration
> due
> > to
> > http://crbug.com/420034
> > If we do it this way, the option will still show in about:flags, but wont
> > do
> > anything.  I don't think we want that either.
>
> > Can't we just revert the change you landed that enabled it by default?
>
> That would bring back the strings for the enable flag. Is that acceptable
> for
> merging?
> Otherwise,  how about removing the not functioning flag and its strings
> instead?
>
> https://codereview.chromium.org/634413002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[xiyuan, 2014-10-09 17:32:01]

PTAL. Thanks.

[Albert Bodenhamer, 2014-10-09 18:32:37]

lgtm

[xiyuan, 2014-10-09 23:34:10]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-10-09 23:35:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634413002/20001

[commit-bot: I haz the power, 2014-10-10 00:47:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-10 00:48:38]

Patchset 2 (id:??) landed as
https://crrev.com/73d29fb89088780502fcae7b82a170c958cf5d8e
Cr-Commit-Position: refs/heads/master@{#299028}