Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634383004: DevTools: add JsDocs to CombineExternalResourcesRule constructor (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
apavlov, aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: add JsDocs to CombineExternalResourcesRule constructor BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/devtools/front_end/audits/AuditRules.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
eustas
6 years, 2 months ago (2014-10-23 11:09:21 UTC) #2
aandrey
lgtm
6 years, 2 months ago (2014-10-23 11:52:53 UTC) #4
apavlov
Please make the issue subject a bit more different than a dozen of similar ones ...
6 years, 2 months ago (2014-10-23 11:54:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634383004/1
6 years, 2 months ago (2014-10-23 13:24:58 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 15:22:11 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184276

Powered by Google App Engine
This is Rietveld 408576698