Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 634343003: change newly added OVERRIDE to override in ash/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

change newly added OVERRIDE to override in ash/ R=jonross@chromium.org,flackr@chromium.org,skuhne@chromium.org BUG=417463 Committed: https://crrev.com/d1ef895e20bd862bb4177104a8964c11b0ad8ae4 Cr-Commit-Position: refs/heads/master@{#298824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/system/tray/system_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_details_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Mostyn Bramley-Moore
@flackr, jonross, Mr4D: please take a look at this tiny fixup...
6 years, 2 months ago (2014-10-08 21:32:28 UTC) #1
jonross
On 2014/10/08 21:32:28, Mostyn Bramley-Moore wrote: > @flackr, jonross, Mr4D: please take a look at ...
6 years, 2 months ago (2014-10-08 21:35:08 UTC) #2
flackr
lgtm
6 years, 2 months ago (2014-10-08 21:42:07 UTC) #3
Mr4D (OOO till 08-26)
lgtm
6 years, 2 months ago (2014-10-08 21:54:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634343003/1
6 years, 2 months ago (2014-10-08 22:02:08 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-09 03:13:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634343003/1
6 years, 2 months ago (2014-10-09 06:05:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as b4b8c03861184add8a3bb8073a1661daeb232453
6 years, 2 months ago (2014-10-09 07:43:07 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 07:43:56 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d1ef895e20bd862bb4177104a8964c11b0ad8ae4
Cr-Commit-Position: refs/heads/master@{#298824}

Powered by Google App Engine
This is Rietveld 408576698