emitIAS for fld and fstp

src/IceInstX8632.cpp

 //===- subzero/src/IceInstX8632.cpp - X86-32 instruction implementation ---===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the InstX8632 and OperandX8632 classes,
@@ skipping 1813 matching lines @@
 template <> void InstX8632MovssRegs::emitIAS(const Cfg *Func) const {
   // This is Binop variant is only intended to be used for reg-reg moves
   // where part of the Dest register is untouched.
   assert(getSrcSize() == 2);
   const Variable *Dest = getDest();
   assert(Dest == getSrc(0));
   const Variable *Src = llvm::cast<Variable>(getSrc(1));
   assert(Dest->hasReg() && Src->hasReg());
   x86::AssemblerX86 *Asm = Func->getAssembler<x86::AssemblerX86>();
   intptr_t StartPosition = Asm->GetPosition();
-  Asm->movss(RegX8632::getEncodedXmm(Dest->getRegNum()),
+  Asm->movss(IceType_f32,
+             RegX8632::getEncodedXmm(Dest->getRegNum()),
              RegX8632::getEncodedXmm(Src->getRegNum()));
   Ostream &Str = Func->getContext()->getStrEmit();
   emitIASBytes(Str, Asm, StartPosition);
 }
 
 void InstX8632Movsx::emit(const Cfg *Func) const {
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 1);
   Str << "\tmovsx\t";
   getDest()->emit(Func);
@@ skipping 66 matching lines @@
     Str << "\n";
     Str << "\tfld\t" << TypeX8632Attributes[Ty].WidthString << " [esp]\n";
     Str << "\tadd\tesp, " << Width << "\n";
     return;
   }
   Str << "\tfld\t";
   getSrc(0)->emit(Func);
   Str << "\n";
 }
 
+void InstX8632Fld::emitIAS(const Cfg *Func) const {
+  x86::AssemblerX86 *Asm = Func->getAssembler<x86::AssemblerX86>();
+  intptr_t StartPosition = Asm->GetPosition();
+  assert(getSrcSize() == 1);
+  const Operand *Src = getSrc(0);
+  Type Ty = Src->getType();
+  if (const auto Var = llvm::dyn_cast<Variable>(Src)) {
+    if (Var->hasReg()) {
+      // This is a physical xmm register, so we need to spill it to a
+      // temporary stack slot.
+      x86::Immediate Width(typeWidthInBytes(Ty));
+      Asm->sub(IceType_i32, RegX8632::Encoded_Reg_esp, Width);
+      x86::Address StackSlot = x86::Address(RegX8632::Encoded_Reg_esp, 0);
+      Asm->movss(Ty, StackSlot, RegX8632::getEncodedXmm(Var->getRegNum()));
+      Asm->fld(Ty, StackSlot);
+      Asm->add(IceType_i32, RegX8632::Encoded_Reg_esp, Width);
+    } else {
+      x86::Address StackAddr(static_cast<TargetX8632 *>(Func->getTarget())
+                                 ->stackVarToAsmOperand(Var));
+      Asm->fld(Ty, StackAddr);
+    }
+  } else if (const auto Mem = llvm::dyn_cast<OperandX8632Mem>(Src)) {
+    Asm->fld(Ty, Mem->toAsmAddress(Asm));
+  } else if (const auto Imm = llvm::dyn_cast<Constant>(Src)) {
+    Asm->fld(Ty, x86::Address::ofConstPool(Func->getContext(), Asm, Imm));
+  } else {
+    llvm_unreachable("Unexpected operand type");
+  }
+  Ostream &Str = Func->getContext()->getStrEmit();
+  emitIASBytes(Str, Asm, StartPosition);
+}
+
 void InstX8632Fld::dump(const Cfg *Func) const {
   Ostream &Str = Func->getContext()->getStrDump();
   Str << "fld." << getSrc(0)->getType() << " ";
   dumpSources(Func);
 }
 
 void InstX8632Fstp::emit(const Cfg *Func) const {
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 0);
-  if (getDest() == NULL) {

[Jim Stichnoth, 2014/10/08 19:09:41]

I think "fstp st(0)" might possibly be used in the future, in the situation that
https://codereview.chromium.org/563303003/ addresses (but addresses in a
different way).

A better way might be to mark the fstp instruction as having side effects, and
allow dead-instruction elimination to "partially" delete the fstp instruction
(or any such instruction) by setting its Dest=NULL.

[jvoung (off chromium), 2014/10/08 20:51:47]

Okay, so the benefit of that is it can avoid allocating a Variable for Dest if
it's unused / avoid conflicts.

I'll add back the check for getDest() == NULL and emit fstp st(0) then, and
leave a note?

[Jim Stichnoth, 2014/10/08 21:10:28]

Yes, thanks!

-    Str << "\tfstp\tst(0)\n";
-    return;
-  }
   if (!getDest()->hasReg()) {
     Str << "\tfstp\t";
     getDest()->emit(Func);
     Str << "\n";
     return;
   }
   // Dest is a physical (xmm) register, so st(0) needs to go through
   // memory.  Hack this by creating a temporary stack slot, spilling
   // st(0) there, loading it into the xmm register, and deallocating
   // the stack slot.
   Type Ty = getDest()->getType();
   size_t Width = typeWidthInBytes(Ty);
   Str << "\tsub\tesp, " << Width << "\n";
   Str << "\tfstp\t" << TypeX8632Attributes[Ty].WidthString << " [esp]\n";
   Str << "\tmov" << TypeX8632Attributes[Ty].SdSsString << "\t";
   getDest()->emit(Func);
   Str << ", " << TypeX8632Attributes[Ty].WidthString << " [esp]\n";
   Str << "\tadd\tesp, " << Width << "\n";
 }
 
+void InstX8632Fstp::emitIAS(const Cfg *Func) const {
+  x86::AssemblerX86 *Asm = Func->getAssembler<x86::AssemblerX86>();
+  intptr_t StartPosition = Asm->GetPosition();
+  assert(getSrcSize() == 0);
+  const Variable *Dest = getDest();
+  Type Ty = Dest->getType();
+  if (!Dest->hasReg()) {
+    x86::Address StackAddr(static_cast<TargetX8632 *>(Func->getTarget())
+                                 ->stackVarToAsmOperand(Dest));
+    Asm->fstp(Ty, StackAddr);
+  } else {
+    // Dest is a physical (xmm) register, so st(0) needs to go through
+    // memory.  Hack this by creating a temporary stack slot, spilling
+    // st(0) there, loading it into the xmm register, and deallocating
+    // the stack slot.
+    x86::Immediate Width(typeWidthInBytes(Ty));
+    Asm->sub(IceType_i32, RegX8632::Encoded_Reg_esp, Width);
+    x86::Address StackSlot = x86::Address(RegX8632::Encoded_Reg_esp, 0);
+    Asm->fstp(Ty, StackSlot);
+    Asm->movss(Ty, RegX8632::getEncodedXmm(Dest->getRegNum()), StackSlot);
+    Asm->add(IceType_i32, RegX8632::Encoded_Reg_esp, Width);
+  }
+  Ostream &Str = Func->getContext()->getStrEmit();
+  emitIASBytes(Str, Asm, StartPosition);
+}
+
 void InstX8632Fstp::dump(const Cfg *Func) const {
   Ostream &Str = Func->getContext()->getStrDump();
   dumpDest(Func);
   Str << " = fstp." << getDest()->getType() << ", st(0)";
   Str << "\n";
 }
 
 template <> void InstX8632Pcmpeq::emit(const Cfg *Func) const {
   char buf[30];
   snprintf(buf, llvm::array_lengthof(buf), "pcmpeq%s",
@@ skipping 414 matching lines @@
   }
   Str << "(";
   if (Func)
     Var->dump(Func);
   else
     Var->dump(Str);
   Str << ")";
 }
 
 } // end of namespace Ice