Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 634313006: Use the function recently added to common in svndiff.py (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
borenet
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use the function recently added to common in svndiff.py GetModifiedFiles() function was added to common repo in https://skia.googlesource.com/common/+/af1de867422c42855ae54ed3838c62ea445ea6b4 BUG=None TEST=None R=borenet@google.com Committed: https://skia.googlesource.com/skia/+/8f1f7f821c8383053bdf747b89d843bbddd84203

Patch Set 1 #

Total comments: 3

Patch Set 2 : roll DEPS + CHECKOUT_ROOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/svndiff.py View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
Please, could you take a look? Thanks, https://codereview.chromium.org/634313006/diff/1/tools/svndiff.py File tools/svndiff.py (right): https://codereview.chromium.org/634313006/diff/1/tools/svndiff.py#newcode49 tools/svndiff.py:49: from common.py.utils ...
6 years, 2 months ago (2014-10-09 03:07:11 UTC) #1
borenet
You'll also need to roll the common repo DEPS to pick up your change. https://codereview.chromium.org/634313006/diff/1/tools/svndiff.py ...
6 years, 2 months ago (2014-10-09 12:14:36 UTC) #2
tfarina
DEPS rolled. I used the commit sha1. Should I have used the tree sha1? I ...
6 years, 2 months ago (2014-10-10 00:03:59 UTC) #3
borenet
On 2014/10/10 00:03:59, tfarina wrote: > DEPS rolled. I used the commit sha1. Should I ...
6 years, 2 months ago (2014-10-10 01:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634313006/20001
6 years, 2 months ago (2014-10-10 03:10:26 UTC) #6
commit-bot: I haz the power
Presubmit check for 634313006-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-10-10 03:10:36 UTC) #8
tfarina
6 years, 2 months ago (2014-10-10 03:26:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8f1f7f821c8383053bdf747b89d843bbddd84203.

Powered by Google App Engine
This is Rietveld 408576698