Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4161)

Unified Diff: chrome/browser/extensions/extension_install_ui.h

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_ui.h
diff --git a/chrome/browser/extensions/extension_install_ui.h b/chrome/browser/extensions/extension_install_ui.h
index 409bfcad28e466cb646a18ad2645aaf0ddbc93da..02d22910a4674075bf727f489cd679facaf75de6 100644
--- a/chrome/browser/extensions/extension_install_ui.h
+++ b/chrome/browser/extensions/extension_install_ui.h
@@ -24,8 +24,6 @@ class ExtensionWebstorePrivateApiTest;
// around extension installation.
class ExtensionInstallUI {
public:
- static ExtensionInstallUI* Create(Profile* profile);
-
virtual ~ExtensionInstallUI();
// Called when an extension was installed.
@@ -48,7 +46,12 @@ class ExtensionInstallUI {
}
// Opens apps UI and animates the app icon for the app with id |app_id|.
- static void OpenAppInstalledUI(Profile* profile, const std::string& app_id);
+ virtual void OpenAppInstalledUI(const std::string& app_id) = 0;
+
+ // Creates an ExtensionInstallPrompt. Caller assumes ownership. This method is
+ // deprecated - do not add new callers.
+ // TODO(pkotwicz): Remove this method. crbug.com/422474
+ virtual ExtensionInstallPrompt* CreateInstallPrompt() = 0;
#if defined(UNIT_TEST)
static void set_disable_failure_ui_for_tests() {
@@ -56,17 +59,6 @@ class ExtensionInstallUI {
}
#endif
- // Creates an ExtensionInstallPrompt from |browser|.
- // Caller assumes ownership.
- static ExtensionInstallPrompt* CreateInstallPromptWithBrowser(
- Browser* browser);
-
- // Creates an ExtensionInstallPrompt from |profile|.
- // Caller assumes ownership. This method is deprecated and should not be used
- // in new code.
- static ExtensionInstallPrompt* CreateInstallPromptWithProfile(
- Profile* profile);
-
Profile* profile() { return profile_; }
protected:
@@ -89,4 +81,10 @@ class ExtensionInstallUI {
DISALLOW_COPY_AND_ASSIGN(ExtensionInstallUI);
};
+namespace chrome {
+
+ExtensionInstallUI* CreateExtensionInstallUI(Profile* profile);
+
+} // namespace chrome
+
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_UI_H_

Powered by Google App Engine
This is Rietveld 408576698