Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser_ui.gypi
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi
index f76d75e248d978b9c30e1adc80dab4b46c9a6f2f..e216c33dd0510051dece86df21b7a5fa82be7ee4 100644
--- a/chrome/chrome_browser_ui.gypi
+++ b/chrome/chrome_browser_ui.gypi
@@ -1417,8 +1417,6 @@
'browser/ui/elide_url.h',
'browser/ui/extensions/application_launch.cc',
'browser/ui/extensions/application_launch.h',
- 'browser/ui/extensions/extension_install_ui_default.cc',
- 'browser/ui/extensions/extension_install_ui_default.h',
'browser/ui/fast_unload_controller.cc',
'browser/ui/fast_unload_controller.h',
'browser/ui/find_bar/find_bar_controller.cc',
@@ -2331,8 +2329,6 @@
'browser/ui/ash/ash_keyboard_controller_proxy.h',
'browser/ui/ash/app_list/app_list_controller_ash.cc',
'browser/ui/ash/app_list/app_list_controller_ash.h',
- 'browser/ui/ash/app_list/app_list_service_ash.cc',
- 'browser/ui/ash/app_list/app_list_service_ash.h',
'browser/ui/ash/app_list/app_sync_ui_state_watcher.cc',
'browser/ui/ash/app_list/app_sync_ui_state_watcher.h',
'browser/ui/ash/app_sync_ui_state.cc',
@@ -2449,6 +2445,11 @@
'browser/ui/views/frame/scroll_end_effect_controller_ash.h',
'browser/ui/views/tabs/window_finder_ash.cc',
],
+ # Used when Ash is enabled but not Athena.
+ 'chrome_browser_ui_ash_non_athena_sources': [
+ 'browser/ui/ash/app_list/app_list_service_ash.cc',
+ 'browser/ui/ash/app_list/app_list_service_ash.h',
+ ],
# Used when Ash is enabled but not ChromeOS.
'chrome_browser_ui_ash_non_chromeos': [
'browser/ui/ash/chrome_shell_delegate_views.cc',
@@ -2459,11 +2460,18 @@
],
# Used when athena is enabled.
'chrome_browser_ui_athena_sources': [
+ 'browser/ui/app_list/app_list_service_disabled.cc',
+ 'browser/ui/athena/extensions/extension_install_ui_athena.cc',
+ 'browser/ui/athena/extensions/extension_install_ui_athena.h',
'browser/ui/views/athena/athena_util.cc',
'browser/ui/views/athena/athena_util.h',
'browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc',
'browser/ui/views/athena/chrome_browser_main_extra_parts_athena.h',
],
+ 'chrome_browser_ui_non_athena_sources': [
+ 'browser/ui/extensions/extension_install_ui_default.cc',
+ 'browser/ui/extensions/extension_install_ui_default.h',
+ ],
# Counts desktop Linux and ChromeOS.
'chrome_browser_ui_linux_sources': [
'browser/ui/startup/autolaunch_prompt.cc',
@@ -2728,6 +2736,13 @@
'<(DEPTH)/athena/athena.gyp:athena_content_lib',
'<(DEPTH)/athena/main/athena_main.gyp:athena_main_lib',
],
+ }, { # use_athena==0
+ 'sources': [ '<@(chrome_browser_ui_non_athena_sources)' ],
+ 'conditions': [
+ ['use_ash==1', {
+ 'sources': [ '<@(chrome_browser_ui_ash_non_athena_sources)' ],
+ }],
+ ],
}],
['toolkit_views==1', {
'sources': [ '<@(chrome_browser_ui_views_sources)' ],

Powered by Google App Engine
This is Rietveld 408576698