Display dialog when app install succeeds / fails on Athena

chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 4a12ad74777e8e8daf0be632455633130525a737..c47b53094e9e6a6bed17843c3e91c93e83b3b80d 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -106,6 +106,12 @@ scoped_ptr<WebstoreInstaller::Approval> PendingApprovals::PopApproval(
   return scoped_ptr<WebstoreInstaller::Approval>();
 }
 
+chrome::HostDesktopType GetHostDesktopTypeForWebContents(
+    content::WebContents* contents) {
+  return chrome::GetHostDesktopTypeForNativeView(
+      contents->GetTopLevelNativeWindow());
+}
+
 static base::LazyInstance<PendingApprovals> g_pending_approvals =
     LAZY_INSTANCE_INITIALIZER;
 
@@ -473,8 +479,8 @@ bool WebstorePrivateCompleteInstallFunction::RunAsync() {
   scoped_active_install_.reset(new ScopedActiveInstall(
       InstallTracker::Get(GetProfile()), params->expected_id));
 
-  AppListService* app_list_service =
-      AppListService::Get(GetCurrentBrowser()->host_desktop_type());
+  AppListService* app_list_service = AppListService::Get(

[Jun Mukai, 2014/10/09 23:34:53]

This warns me a bit.  Right now Athena doesn't use AppListService at all. This
is still safe, we'll have AppListServiceAsh here, and AppListServiceAsh does
nothing for EnableAppList (because it's enabled by default).

I am not sure what's the best approach here.  This code looks good, but simply
ifndef ENABLE_ATHENA might be acceptable for the time being.

[pkotwicz, 2014/10/10 00:51:31]

I changed the gyp includes such that Athena uses app_list_service_disabled.cc

I am unsure what the long term direction should be. We could send people to the
home card when they install an app. (I don't think we should, but we could)

Using app_List_service_disabled.cc is the most minimal change possible. We need
to make this change in order to componentize the webstore private API anyways

[Jun Mukai, 2014/10/10 01:01:08]

That seems a right direction to me. Eventually I will have to put AppListService
for athena, but it's not gonna happen soon. Thanks for doing this.

+      GetHostDesktopTypeForWebContents(GetAssociatedWebContents()));
 
   if (approval_->enable_launcher) {
     app_list_service->EnableAppList(GetProfile(),
@@ -568,8 +574,10 @@ WebstorePrivateEnableAppLauncherFunction::
     ~WebstorePrivateEnableAppLauncherFunction() {}
 
 bool WebstorePrivateEnableAppLauncherFunction::RunSync() {
-  AppListService::Get(GetCurrentBrowser()->host_desktop_type())
-      ->EnableAppList(GetProfile(), AppListService::ENABLE_VIA_WEBSTORE_LINK);
+  AppListService* app_list_service = AppListService::Get(
+      GetHostDesktopTypeForWebContents(GetAssociatedWebContents()));
+  app_list_service->EnableAppList(GetProfile(),
+                                  AppListService::ENABLE_VIA_WEBSTORE_LINK);
   return true;
 }