chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 634313004: Display dialog when app install succeeds / fails on Athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/athena/extensions/extension_install_ui_factory_athena.cc ('k') | chrome/browser/ui/extensions/extension_install_ui_default.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 25a15630dba84d6a0e0af77772928d18d6e28d4c..637eb393fae4738fa4c8cbc110495a76a9a2900e 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -7,6 +7,7 @@

#include "base/i18n/rtl.h"

#include "base/mac/bundle_locations.h"

#include "base/mac/mac_util.h"

+#include "base/memory/scoped_ptr.h"

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/chrome_notification_types.h"

@@ -14,7 +15,6 @@

#include "chrome/browser/extensions/bundle_installer.h"

#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/extensions/extension_action_manager.h"

-#include "chrome/browser/extensions/extension_install_ui.h"

#include "chrome/browser/signin/signin_promo.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_navigator.h"

@@ -29,6 +29,7 @@

#include "chrome/browser/ui/cocoa/new_tab_button.h"

#include "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"

#include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"

+#include "chrome/browser/ui/extensions/extension_install_ui_factory.h"

#include "chrome/browser/ui/singleton_tabs.h"

#include "chrome/browser/ui/sync/sync_promo_ui.h"

#include "chrome/common/extensions/api/commands/commands_handler.h"

@@ -41,6 +42,7 @@

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_source.h"

+#include "extensions/browser/install/extension_install_ui.h"

#include "extensions/common/extension.h"

#import "skia/ext/skia_utils_mac.h"

#import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"

@@ -694,7 +696,9 @@ class ExtensionLoadedNotificationObserver

}

- (IBAction)onAppShortcutClicked:(id)sender {

- ExtensionInstallUI::OpenAppInstalledUI(browser_->profile(), extension_->id());

+ scoped_ptr<extensions::ExtensionInstallUI> install_ui(

+ extensions::CreateExtensionInstallUI(browser_->profile()));

+ install_ui->OpenAppInstalledUI(extension_->id());

}

- (void)awakeFromNib {