chrome/browser/extensions/unpacked_installer.cc - Issue 634313004: Display dialog when app install succeeds / fails on Athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/navigation_observer.cc ('k') | chrome/browser/extensions/webstore_standalone_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index c951c8cf7bb8f2cf22e14f649a567b9a89338347..cf49ab36405621608f8a57733fe752731f616d85 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -11,16 +11,17 @@

#include "base/threading/thread_restrictions.h"

#include "chrome/browser/extensions/extension_error_reporter.h"

#include "chrome/browser/extensions/extension_install_prompt.h"

-#include "chrome/browser/extensions/extension_install_ui.h"

#include "chrome/browser/extensions/extension_management.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/permissions_updater.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/extensions/extension_install_ui_factory.h"

#include "chrome/common/extensions/api/plugins/plugins_handler.h"

#include "components/crx_file/id_util.h"

#include "content/public/browser/browser_thread.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/browser/install/extension_install_ui.h"

#include "extensions/browser/install_flag.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_l10n_util.h"

@@ -67,10 +68,11 @@ SimpleExtensionLoadPrompt::SimpleExtensionLoadPrompt(

const Extension* extension,

Profile* profile,

const base::Closure& callback)

- : install_ui_(ExtensionInstallUI::CreateInstallPromptWithProfile(

- profile)),

- extension_(extension),

- callback_(callback) {

+ : extension_(extension), callback_(callback) {

+ scoped_ptr<extensions::ExtensionInstallUI> ui(

+ extensions::CreateExtensionInstallUI(profile));

+ install_ui_.reset(new ExtensionInstallPrompt(

+ profile, ui->GetDefaultInstallDialogParent(), NULL));

}

SimpleExtensionLoadPrompt::~SimpleExtensionLoadPrompt() {

« no previous file with comments | « chrome/browser/extensions/navigation_observer.cc ('k') | chrome/browser/extensions/webstore_standalone_installer.cc » ('j') | no next file with comments »