Display dialog when app install succeeds / fails on Athena

chrome/chrome_browser_ui.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chrome_browser_ui_non_ios_sources': [
       'browser/ui/accelerator_utils.h',
       'browser/ui/android/android_about_app_info.cc',
       'browser/ui/android/android_about_app_info.h',
@@ skipping 1401 matching lines @@
       'browser/ui/content_settings/content_setting_image_model.cc',
       'browser/ui/content_settings/content_setting_image_model.h',
       'browser/ui/content_settings/content_setting_media_menu_model.cc',
       'browser/ui/content_settings/content_setting_media_menu_model.h',
       'browser/ui/elide_url.cc',
       'browser/ui/elide_url.h',
       'browser/ui/extensions/application_launch.cc',
       'browser/ui/extensions/application_launch.h',
       'browser/ui/extensions/extension_install_ui_default.cc',
       'browser/ui/extensions/extension_install_ui_default.h',
+      'browser/ui/extensions/extension_install_ui_factory.h',
       'browser/ui/fast_unload_controller.cc',
       'browser/ui/fast_unload_controller.h',
       'browser/ui/find_bar/find_bar_controller.cc',
       'browser/ui/find_bar/find_bar_controller.h',
       'browser/ui/fullscreen/fullscreen_controller.cc',
       'browser/ui/fullscreen/fullscreen_controller.h',
       'browser/ui/fullscreen/fullscreen_exit_bubble.cc',
       'browser/ui/fullscreen/fullscreen_exit_bubble.h',
       'browser/ui/fullscreen/fullscreen_exit_bubble_type.cc',
       'browser/ui/fullscreen/fullscreen_exit_bubble_type.h',
@@ skipping 1017 matching lines @@
       'browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h',
     ],
     # Used when Ash is enabled but not ChromeOS.
     'chrome_browser_ui_ash_non_chromeos': [
       'browser/ui/ash/chrome_shell_delegate_views.cc',
       'browser/ui/ash/multi_user/multi_user_context_menu.cc',
       'browser/ui/ash/multi_user/multi_user_context_menu.h',
       'browser/ui/ash/session_state_delegate_views.cc',
       'browser/ui/ash/session_state_delegate_views.h',
     ],
+    # Used when not using android and not using Athena.
+    'chrome_browser_ui_non_athena_non_android_sources': [

[Ken Rockot(use gerrit already), 2014/10/15 22:20:08]

This is extremely unfortunate. I would like this to not be necessary.

+      'browser/ui/extensions/extension_install_ui_factory.cc', 
+    ],
     # Used when athena is enabled.
     'chrome_browser_ui_athena_sources': [
       #TODO(mukai): Port AppListService to Athena (crbug.com/417571)
       'browser/ui/app_list/app_list_service_disabled.cc',
 
+      'browser/ui/athena/extensions/extension_install_ui_factory_athena.cc', 
       'browser/ui/views/athena/athena_util.cc',
       'browser/ui/views/athena/athena_util.h',
       'browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc',
       'browser/ui/views/athena/chrome_browser_main_extra_parts_athena.h',
     ],
     # Counts desktop Linux and ChromeOS.
     'chrome_browser_ui_linux_sources': [
       'browser/ui/startup/autolaunch_prompt.cc',
       'browser/ui/views/apps/chrome_apps_client_views.cc',
       'browser/ui/views/frame/taskbar_decorator.cc',
@@ skipping 251 matching lines @@
           'defines': ['USE_ATHENA=1'],
           'sources': [ '<@(chrome_browser_ui_athena_sources)' ],
           'dependencies': [
             '<(DEPTH)/athena/athena.gyp:athena_lib',
             '<(DEPTH)/athena/athena.gyp:athena_chrome_lib',
             '<(DEPTH)/athena/athena.gyp:athena_content_lib',
             '<(DEPTH)/athena/main/athena_main.gyp:athena_main_lib',
           ],
         }, { # use_athena==0
           'conditions': [
+            ['OS!="android"', {
+              'sources': [ '<@(chrome_browser_ui_non_athena_non_android_sources)' ],
+            }],
             ['use_ash==1', {
               'sources': [ '<@(chrome_browser_ui_ash_non_athena_sources)' ],
             }],
           ],
         }],
         ['toolkit_views==1', {
           'sources': [ '<@(chrome_browser_ui_views_sources)' ],
           'conditions': [
             ['chromeos == 0 and OS!="mac"', {
               'sources': [ '<@(chrome_browser_ui_views_non_chromeos_sources)' ],
@@ skipping 261 matching lines @@
         }],
         ['OS!="android" and OS!="ios"', {
           'dependencies': [
             '../device/bluetooth/bluetooth.gyp:device_bluetooth',
           ],
         }],
       ],
     },
   ],
 }