chrome/browser/DEPS - Issue 634313004: Display dialog when app install succeeds / fails on Athena

Side by Side Diff: chrome/browser/DEPS

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « athena/extensions/shell/extensions_delegate_impl.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | chrome/browser/ui/extensions/extension_install_ui_default.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+apps",	2 "+apps",

3 "+ash",	3 "+ash",

4 "+athena/content/public",	4 "+athena/content/public",

	5 "+athena/extensions/public",
	oshima 2014/10/14 16:57:58 can you move this to c/b/ui/extensions ? can you move this to c/b/ui/extensions ? pkotwicz 2014/10/14 21:44:51 chrome/browser/ui/extensions/DEPS does not exist s chrome/browser/ui/extensions/DEPS does not exist so its probably best to leave this here for now Ken Rockot(use gerrit already) 2014/10/14 22:18:58 It seems supremely weird to see athena listed anyw Show quoted text On 2014/10/14 21:44:51, pkotwicz wrote: > chrome/browser/ui/extensions/DEPS does not exist so its probably best to leave > this here for now It seems supremely weird to see athena listed anywhere in chrome DEPS (or really in any deps outside of athena itself.) But in this case especially, I don't even see where a real dependency on athena/extensions/public is being introduced. Why is this needed? pkotwicz 2014/10/14 22:29:08 This is needed for the include in chrome/browser/u This is needed for the include in chrome/browser/ui/extensions/extension_install_ui_factory.cc oshima 2014/10/14 22:31:08 Chrome is starting point, so we need minimum athen Show quoted text On 2014/10/14 22:18:58, Ken Rockot wrote: > On 2014/10/14 21:44:51, pkotwicz wrote: > > chrome/browser/ui/extensions/DEPS does not exist so its probably best to leave > > this here for now > > It seems supremely weird to see athena listed anywhere in chrome DEPS (or really > in any deps outside of athena itself.) > > But in this case especially, I don't even see where a real dependency on > athena/extensions/public is being introduced. Why is this needed? Chrome is starting point, so we need minimum athena dependency inside chrome to inject athena shell. We can create a bridge class in chrome/browser/ui/views/athena, and avoid direct //athena dependency, if you're ok with it. That allow us to control the //athena dependency in //chrome more easily.
5 "+chrome/app",	6 "+chrome/app",

6 "+chrome/grit", # For generated headers	7 "+chrome/grit", # For generated headers

7 "+chrome/installer",	8 "+chrome/installer",

8 "+chrome_elf/blacklist",	9 "+chrome_elf/blacklist",

9 "+chrome_elf/chrome_elf_constants.h",	10 "+chrome_elf/chrome_elf_constants.h",

10 "+chrome_elf/create_file",	11 "+chrome_elf/create_file",

11 "+chrome_elf/dll_hash",	12 "+chrome_elf/dll_hash",

12 "+chromeos",	13 "+chromeos",

13 "+components/autofill/content/browser",	14 "+components/autofill/content/browser",

14 "+components/autofill/content/common",	15 "+components/autofill/content/common",

(...skipping 144 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
159 "+third_party/WebKit/public/web/WebCache.h",	160 "+third_party/WebKit/public/web/WebCache.h",

160 "+third_party/WebKit/public/web/WebContextMenuData.h",	161 "+third_party/WebKit/public/web/WebContextMenuData.h",

161 "+third_party/WebKit/public/web/WebFindOptions.h",	162 "+third_party/WebKit/public/web/WebFindOptions.h",

162 "+third_party/WebKit/public/web/WebInputEvent.h",	163 "+third_party/WebKit/public/web/WebInputEvent.h",

163 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",	164 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",

164 "+third_party/WebKit/public/web/WebPageVisibilityState.h",	165 "+third_party/WebKit/public/web/WebPageVisibilityState.h",

165 "+third_party/WebKit/public/web/WebPluginAction.h",	166 "+third_party/WebKit/public/web/WebPluginAction.h",

166 "+third_party/WebKit/public/web/WebTextDirection.h",	167 "+third_party/WebKit/public/web/WebTextDirection.h",

167 "+third_party/WebKit/public/web/WebWindowFeatures.h",	168 "+third_party/WebKit/public/web/WebWindowFeatures.h",

168 ]	169 ]

OLD	NEW