athena/extensions/chrome/public/extension_install_ui_factory.h - Issue 634313004: Display dialog when app install succeeds / fails on Athena

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: athena/extensions/chrome/public/extension_install_ui_factory.h

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ATHENA_EXTENSIONS_CHROME_PUBLIC_EXTENSION_INSTALL_UI_FACTORY_H_

	6 #define ATHENA_EXTENSIONS_CHROME_PUBLIC_EXTENSION_INSTALL_UI_FACTORY_H_

	7

	8 class ExtensionInstallUI;

	9 class Profile;

	10

	11 namespace athena {

	12

	13 ExtensionInstallUI* CreateExtensionInstallUI(Profile* profile);
	oshima 2014/10/11 02:10:27 how about move this to ExtensionsDelegate? how about move this to ExtensionsDelegate? pkotwicz 2014/10/12 02:05:32 That would be difficult because ExtensionsDelegate That would be difficult because ExtensionsDelegate cannot depend on chrome and both ExtensionInstallUI and Profile are defined in Chrome. Switching to using BrowserContext instead of Profile is non-trivial and maybe not possible. I suspect that in practice moving this to ExtensionsDelegate is OK because we can forward declare ExtensionInstallUI and Profile, but that's sooo ugly.
	14

	15 } // namespace athena

	16

	17 #endif // ATHENA_EXTENSIONS_CHROME_PUBLIC_EXTENSION_INSTALL_UI_FACTORY_H_

OLD	NEW

« no previous file with comments | « athena/extensions/chrome/public/DEPS ('k') | chrome/browser/DEPS » ('j') | no next file with comments »