chrome/browser/ui/athena/extensions/extension_install_ui_athena.h - Issue 634313004: Display dialog when app install succeeds / fails on Athena

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/athena/extensions/extension_install_ui_athena.h

Issue 634313004: Display dialog when app install succeeds / fails on Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/ash/chrome_shell_delegate.cc ('k') | chrome/browser/ui/athena/extensions/extension_install_ui_athena.cc » ('j') | chrome/browser/ui/athena/extensions/extension_install_ui_athena.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #include "base/memory/scoped_ptr.h"

	2 #include "chrome/browser/extensions/extension_install_ui.h"
	oshima 2014/10/09 19:44:48 we should not have athena code under c/b/ except v we should not have athena code under c/b/ except very thin glue code. can you move this to athena/extensions ?
	3

	4 class ExtensionInstallUIAthena : public ExtensionInstallUI {

	5 public:

	6 explicit ExtensionInstallUIAthena(Profile* profile);

	7 virtual ~ExtensionInstallUIAthena();

	8

	9 // ExtensionInstallUI:

	10 virtual void OnInstallSuccess(const extensions::Extension* extension,

	11 const SkBitmap* icon) OVERRIDE;

	12 virtual void OnInstallFailure(

	13 const extensions::CrxInstallerError& error) OVERRIDE;

	14 virtual void SetUseAppInstalledBubble(bool use_bubble) OVERRIDE;

	15

	16 private:

	17 DISALLOW_COPY_AND_ASSIGN(ExtensionInstallUIAthena);

	18 };

OLD	NEW