Improve reliability of EME tests

Improve reliability of EME tests

The logs for these EME tests expect all the "onencrypted" events to
occur before the "message" event is received. Modify the tests to
create the session on the second event rather than the first, to avoid
the "message" event occasionally happening before the second
"onencrypted" event".

BUG=407993
TEST=modified tests still pass

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183833

[jrummell, 2014-10-14 17:48:23]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org, xhwang@chromium.org

[jrummell, 2014-10-14 17:48:24]

PTAL. Fixes one set of tests for the EVENT(...) messages occurring in different
orders.

[sandersd (OOO until July 31), 2014-10-14 18:10:55]

lgtm.

May be worth changing the comments to say audio/video so that it's clear why
there are exactly two streams.

[ddorwin, 2014-10-15 23:36:20]

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
File LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html
(right):

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html:31: //
create a shared session once. To avoid timing issues with
Any idea what "shared" means?

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html:32: //
the "message" event being received before the second
We should be specific about this being related to the expected logs. There's no
functional timing issue.

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html:34: //
event.
...This also ensures we see both events.

Maybe we should add a check to ensure we don't get a third.

[jrummell, 2014-10-16 00:43:45]

Updated the comments.

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
File LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html
(right):

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html:31: //
create a shared session once. To avoid timing issues with
On 2014/10/15 23:36:20, ddorwin wrote:
> Any idea what "shared" means?

Changed.

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html:32: //
the "message" event being received before the second
On 2014/10/15 23:36:20, ddorwin wrote:
> We should be specific about this being related to the expected logs. There's
no
> functional timing issue.

Done.

https://codereview.chromium.org/634243005/diff/1/LayoutTests/media/encrypted-...
LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html:34: //
event.
On 2014/10/15 23:36:20, ddorwin wrote:
> ...This also ensures we see both events.
> 
> Maybe we should add a check to ensure we don't get a third.

Comment added. expected.txt file ensures it fails if we get a third (or only
one).

[ddorwin, 2014-10-16 15:59:20]

lgtm

[jrummell, 2014-10-16 17:23:28]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-10-16 17:23:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/634243005/20001

[commit-bot: I haz the power, 2014-10-16 19:15:29]

Committed patchset #2 (id:20001) as 183833