Oilpan: Simplify Heap::allocate

Source/platform/heap/HeapTest.cpp

Index: Source/platform/heap/HeapTest.cpp
diff --git a/Source/platform/heap/HeapTest.cpp b/Source/platform/heap/HeapTest.cpp
index 9dcfd8d19d3ea408a74076f1fe0ce33f77ed4ee9..397aa183ef0a6c03d3ce06def612e235d99e76d0 100644
--- a/Source/platform/heap/HeapTest.cpp
+++ b/Source/platform/heap/HeapTest.cpp
@@ -228,7 +228,7 @@ static void getHeapStats(HeapStats* stats)
 {
     TestGCScope scope(ThreadState::NoHeapPointersOnStack);
     EXPECT_TRUE(scope.allThreadsParked());
-    Heap::getStats(stats);
+    Heap::getStatsForTesting(stats);
 }
 
 #define DEFINE_VISITOR_METHODS(Type)                                       \
@@ -1602,7 +1602,6 @@ TEST(HeapTest, BasicFunctionality)
     if (testPagesAllocated)
         EXPECT_EQ(0ul, heapStats.totalAllocatedSpace() & (blinkPageSize - 1));
 
-    DynamicallySizedObject* bigAreaRaw = bigArea;
     // Clear the persistent, so that the big area will be garbage collected.
     bigArea.release();
     clearOutOldGarbage(&heapStats);
@@ -1614,17 +1613,6 @@ TEST(HeapTest, BasicFunctionality)
     if (testPagesAllocated)
         EXPECT_EQ(0ul, heapStats.totalAllocatedSpace() & (blinkPageSize - 1));
 
-    // Endless loop unless we eventually get the memory back that we just freed.

[haraken, 2014/10/23 04:20:50]

Removed this test because the test result depends on how the allocator reuses
the memory address space and thus is not deterministic.

-    while (true) {
-        Persistent<DynamicallySizedObject>* alloc = new Persistent<DynamicallySizedObject>(DynamicallySizedObject::create(big / 2));
-        slack += 4;
-        persistents[persistentCount++] = alloc;
-        EXPECT_LT(persistentCount, numPersistents);
-        total += big / 2;
-        if (bigAreaRaw == alloc->get())
-            break;
-    }
-
     getHeapStats(&heapStats);
     CheckWithSlack(baseLevel + total, heapStats.totalObjectSpace(), slack);
     if (testPagesAllocated)