Run google_apis_unittests on chromeos bots.

Run google_apis_unittests on chromeos bots.

BUG=257421
R=stip@chromium.org,joi@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=235399

[tfarina, 2013-11-11 21:56:08]

Based on https://chromiumcodereview.appspot.com/11971031

[Jói, 2013-11-11 22:29:10]

Looks good to me, thanks Thiago! Please wait until stip@ approves since I
don't really know this stuff.

Cheers,
Jói



On Mon, Nov 11, 2013 at 9:56 PM, <tfarina@chromium.org> wrote:

> Reviewers: Jói, stip,
>
> Message:
> Based on https://chromiumcodereview.appspot.com/11971031
>
> Description:
> Run google_apis_unittests on chromeos bots.
>
> BUG=257421
> R=stip@chromium.org,joi@chromium.org
>
> Please review this at https://chromiumcodereview.appspot.com/63423007/
>
> SVN Base: https://chromium.googlesource.com/chromium/tools/build@master
>
> Affected files (+3, -0 lines):
>   M masters/master.chromium.chromiumos/master_chromiumos_cfg.py
>   M masters/master.chromium.chromiumos/master_gatekeeper_cfg.py
>
>
> Index: masters/master.chromium.chromiumos/master_chromiumos_cfg.py
> diff --git a/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
> b/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
> index 64a1f7bf1e8e1e1bd0538db9836de85d46b1f241..
> 9e14c3b7936296c8d361c6ec3a256cbd38e2eb03 100644
> --- a/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
> +++ b/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
> @@ -40,6 +40,7 @@ sharded_tests = [
>    'content_unittests',
>    'crypto_unittests',
>    'device_unittests',
> +  'google_apis_unittests',
>    'gpu_unittests',
>    'jingle_unittests',
>    'media_unittests',
> @@ -70,6 +71,7 @@ linux_chromeos_tests = [
>    ('crypto_unittests', 'crypto_unittests', 1),
>    ('dbus', 'dbus_unittests', 1),
>    ('device_unittests', 'device_unittests', 1),
> +  ('google_apis_unittests', 'google_apis_unittests', 1),
>    ('gpu', 'gpu_unittests', 1),
>    ('googleurl', 'url_unittests', 1),
>    (None, 'url_unittests', 1),
> Index: masters/master.chromium.chromiumos/master_gatekeeper_cfg.py
> diff --git a/masters/master.chromium.chromiumos/master_gatekeeper_cfg.py
> b/masters/master.chromium.chromiumos/master_gatekeeper_cfg.py
> index 336c8aabf8f9d8831d1f4a7829dc6453f338810b..
> a2a5a104f8301961edd098a6fbd523aa30b9af62 100644
> --- a/masters/master.chromium.chromiumos/master_gatekeeper_cfg.py
> +++ b/masters/master.chromium.chromiumos/master_gatekeeper_cfg.py
> @@ -26,6 +26,7 @@ chromium_categories_steps = {
>      'crypto_unittests',
>      'dbus_unittests',
>      'device_unittests',
> +    'google_apis_unittests',
>      'installer_util_unittests',
>      'interactive_ui_tests',
>      'ipc_tests',
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2013-11-12 13:26:21]

Strange, I didn't receive Joi's message in my INBOX.

Mike, friendly ping (I know you are loaded with reviews though ;))?

[ghost stip (do not use), 2013-11-12 19:16:28]

https://chromiumcodereview.appspot.com/63423007/diff/1/masters/master.chromiu...
File masters/master.chromium.chromiumos/master_chromiumos_cfg.py (right):

https://chromiumcodereview.appspot.com/63423007/diff/1/masters/master.chromiu...
masters/master.chromium.chromiumos/master_chromiumos_cfg.py:43:
'google_apis_unittests',
if it's on gatekeeper, then it needs to be in commit-queue's projects.py.

[tfarina, 2013-11-12 19:32:13]

https://chromiumcodereview.appspot.com/63423007/diff/1/masters/master.chromiu...
File masters/master.chromium.chromiumos/master_chromiumos_cfg.py (right):

https://chromiumcodereview.appspot.com/63423007/diff/1/masters/master.chromiu...
masters/master.chromium.chromiumos/master_chromiumos_cfg.py:43:
'google_apis_unittests',
On 2013/11/12 19:16:28, stip wrote:
> if it's on gatekeeper, then it needs to be in commit-queue's projects.py.

of course I didn't know I was putting it on a gatekeeper.

Is gatekeeper a tree closer? Is that what it means?

I'll checkout commit-queue code and add the entries for google_apis_unittests
here:

https://chromium.googlesource.com/chromium/tools/commit-queue/+/master/projec...

[ghost stip (do not use), 2013-11-14 02:21:38]

lgtm. please coordinate with a trooper before committing/landing

see https://chromiumcodereview.appspot.com/70953003/ for corresponding
projects.py change

[commit-bot: I haz the power, 2013-11-15 19:19:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/63423007/1

[commit-bot: I haz the power, 2013-11-15 19:19:12]

Failed to apply patch for
build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
  Hunk #1 FAILED at 40.
  Hunk #2 FAILED at 70.
  2 out of 2 hunks FAILED -- saving rejects to file
build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py.rej

Patch:       build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
Index: masters/master.chromium.chromiumos/master_chromiumos_cfg.py
diff --git build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
index
64a1f7bf1e8e1e1bd0538db9836de85d46b1f241..9e14c3b7936296c8d361c6ec3a256cbd38e2eb03
100644
--- a/build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
+++ b/build/masters/master.chromium.chromiumos/master_chromiumos_cfg.py
@@ -40,6 +40,7 @@ sharded_tests = [
   'content_unittests',
   'crypto_unittests',
   'device_unittests',
+  'google_apis_unittests',
   'gpu_unittests',
   'jingle_unittests',
   'media_unittests',
@@ -70,6 +71,7 @@ linux_chromeos_tests = [
   ('crypto_unittests', 'crypto_unittests', 1),
   ('dbus', 'dbus_unittests', 1),
   ('device_unittests', 'device_unittests', 1),
+  ('google_apis_unittests', 'google_apis_unittests', 1),
   ('gpu', 'gpu_unittests', 1),
   ('googleurl', 'url_unittests', 1),
   (None, 'url_unittests', 1),

[commit-bot: I haz the power, 2013-11-15 19:24:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/63423007/120001

[commit-bot: I haz the power, 2013-11-15 19:25:18]

Change committed as 235399