Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 63423004: Introduce %_IsMinusZero. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : x64 port #

Patch Set 3 : arm port and small fixes #

Patch Set 4 : extended test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -1 line) Patch
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/hydrogen-minus-zero.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 chunks +17 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/minus-zero.js View 1 2 3 2 chunks +57 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Please take a look. I'll port to x64 and arm in following patch sets.
7 years, 1 month ago (2013-11-11 14:04:50 UTC) #1
Yang
On 2013/11/11 14:04:50, Yang wrote: > Please take a look. > > I'll port to ...
7 years, 1 month ago (2013-11-12 09:29:07 UTC) #2
Jakob Kummerow
LGTM. For the record: as discussed, we could save some lithium-codegen code by blacklisting Tagged ...
7 years, 1 month ago (2013-11-12 11:42:09 UTC) #3
Yang
7 years, 1 month ago (2013-11-12 11:53:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r17639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698